wiki.pages registers pages for all registered meta-sites

joshuabenuck / seran-wiki

Experiment to create a Deno based implementation of Federated Wiki

MIT License

11 stars 7 forks source link

wiki.pages registers pages for all registered meta-sites #30

Closed joshuabenuck closed 4 years ago

joshuabenuck commented 4 years ago

Steps to reproduce:

Check out seran-scrape as a peer to seran-wiki
In seran-wiki run ./seran-wiki.sh ../scrape.ts ./meta-sites
Go to: http://seran.localtest.me:8000/index.html?page=federation-scraper

Expected results:

Only the scrape.localtest.me meta-site has a page named Federation Scraper.

WardCunningham commented 4 years ago

This must be a scope of variable problem when I moved the implementation out of the meta-site that it initially served.

joshuabenuck commented 4 years ago

I agree. Perhaps we could add a parameter to the function that is the metaPages object to use when adding the pages? Or we could just return an object with the created pages and callers could Object.assign to merge it with their local metaPages?

joshuabenuck commented 4 years ago

Fixed by https://github.com/joshuabenuck/seran-wiki/commit/f0153d240ff6420282001967e6b7a72196e21ba0