search

joshuaclayton / polylines

Easily handle Google polylines
MIT License
93 stars 17 forks source link

not thread safe? #4

Closed joecode closed 10 years ago

joecode commented 10 years ago

Was seeing very odd behavior (encoded lines suddenly becoming null) in production server. Looked over code and it seems there are some class level variables that might be overridden by competing threads. I didn't have time to fork and fix it, but thought I should mention this. We switched to https://github.com/nayutaya/googlemaps-polyline and things are back to normal.

joshuaclayton commented 10 years ago

hey @joecode, I looked over it and realized it was still using autoload. I've swapped that with require, which should address this! I looked over the code and couldn't find any class-level state, but if there's something I'm missing, mind passing along the file(s)/line(s)?

joshuaclayton commented 10 years ago

@joecode also, I bumped the gem version to 0.2.0 and pushed to Rubygems

joecode commented 10 years ago

Great, thanks Joshua! The code uses some ruby constructs which I am not quite familiar with, so class level state was just a guess based on behavior and a cursory look-over. I'll test it out again soon and let you know for sure, but autoload definitely sounds like the culprit.