search

joshuadavidnelson / disable-blog

All the power of WordPress, without a blog. This plugin removes blog related functionality.
https://wordpress.org/plugins/disable-blog/
GNU General Public License v2.0
52 stars 6 forks source link

Add 3 basic zero-coverage tests to CI #24

Closed szepeviktor closed 4 years ago

szepeviktor commented 4 years ago
  1. syntax check
  2. coding standard
  3. static analysis

What do you think?

joshuadavidnelson commented 4 years ago

Hey @szepeviktor - thanks for the PR and this suggestion. I'd love to get some testing setup, I've just been swamped with many other things, but it's been on my list of "like to haves" for a while. I don't have any solid eta or roadmap for it at the moment.

szepeviktor commented 4 years ago

Done!

The only thing remaining is following WPCS.

What do you think about it?

joshuadavidnelson commented 4 years ago

That's awesome, I really appreciate the contribution! I'm all for WPCS checks, too.

szepeviktor commented 4 years ago

Done.

kép

Two TODOs for you

  1. reach Level max in PHPStan level: max
  2. use all rules of WPCS vendor/bin/phpcs --standard=WordPress *.php includes/

Estimated execution time: ~2 hours