joshuadavidnelson / disable-blog

All the power of WordPress, without a blog. This plugin removes blog related functionality.
https://wordpress.org/plugins/disable-blog/
GNU General Public License v2.0
52 stars 6 forks source link

v0.4.9 #37

Closed joshuadavidnelson closed 4 years ago

joshuadavidnelson commented 4 years ago

Includes the following:

joshuadavidnelson commented 4 years ago

Hey @szepeviktor and @chesio - any chance you would be able/willing to review these changes? There is a lot of improvements here and some overlap with #36, I would be grateful for a second and/or third pair of eyes before release. Thanks again for your contributions so far!

szepeviktor commented 4 years ago

Hello Joshua! I refer you to these 3 basic tools: https://github.com/joshuadavidnelson/disable-blog/pull/27/files#diff-d948ac4d33809eeb8eafe9eb59a6d05a Please merge that PR or use these 3 tools in any other way.

After that I would gladly review your code ❤️

szepeviktor commented 4 years ago

Please consider moving old-style todo-in-code to sustainable GitHub Issue.

joshuadavidnelson commented 4 years ago

Hey Viktor! Thanks for the quick feedback. I have to move onto other things today, but my next task is to circle back to your PR. I'll try to get that integrated into this PR in the next day or two and then I'll reach out again. Thanks for the help!

szepeviktor commented 4 years ago

Requires at least: 3.1.0

Does it mean that disable-blog must be able to run on PHP 5.2?

joshuadavidnelson commented 4 years ago

Requires at least: 3.1.0

Does it mean that disable-blog must be able to run on PHP 5.2?

Hmm, I guess it could be interpreted that way based on the core PHP compatibility. I haven't updated the min WP version in some time, it was originally based on this tool, but I believe that tool only checks for WordPress functions used in the plugin to determine the minimum version.

I could update the Requires at least to WP 5.2 in order to drop the older versions of PHP and/or add the Requires PHP header to the readme.txt. My preference is provide a reasonable level of backwards compatibility, but honestly I'd rather see PHP 7.0 and greater. That said, we're testing from 5.3 and up, so that would be a good middle ground and provide a large net of backwards compatibility

joshuadavidnelson commented 4 years ago

Huzaah! Took a little time to get all those checks passed, aside from moving abroad this last month I've also setup a new computer - so finding time to work on this took some time, and then getting vscode to replicate the checks being run in github correctly took some trail-and-error. I haven't gone back through to manually check that all the plugin functionality is working as expected, but I will over the weekend.

joshuadavidnelson commented 4 years ago

I went back through this and since I've updated the post_type arguments to make posts non-public, etc there were some functions that could be removed, also wiping out the default supports argument for posts - this pulls posts out of a variety of places in the admin.