Fix erroneous redirection of tools.php subpages.

joshuadavidnelson / disable-blog

All the power of WordPress, without a blog. This plugin removes blog related functionality.

https://wordpress.org/plugins/disable-blog/

GNU General Public License v2.0

52 stars 6 forks source link

Fix erroneous redirection of tools.php subpages. #9

Closed greatislander closed 8 years ago

greatislander commented 8 years ago

The redirection rule for 'Available Tools' introduced in v0.4.0 returns true for custom admin pages under tools.php via add_submenu_page, which I don't think is desired behaviour (This change broke Migrate DB Pro and and I expect other plugins as well.) This PR redirects away from tools.php only if $_GET['page'] is empty, which should maintain the desired functionality without impacting other plugins.

greatislander commented 8 years ago

Ack, sorry, probably should have made this PR against the develop branch. I can resubmit if you like. Thanks for all your work on this plugin!

joshuadavidnelson commented 8 years ago

@greatislander Thanks for this catch! No worries on the branch, I'll merge into master and update things from there.