search

joshuaferrara / go-satellite

Calculate orbital information of satellites in GoLang.
BSD 2-Clause "Simplified" License
78 stars 27 forks source link

linter first pass #7

Open akhenakh opened 4 years ago

akhenakh commented 4 years ago

First pass at Go linters, also see https://github.com/joshuaferrara/go-satellite/issues/5

tests are passing

joshuaferrara commented 4 years ago

See my comment in #5 , but the gist of some of these unused variables seems to be that they're actually meant to be outputs of the function. Rather than deleting these, we should return them and set values appropriately wherever these functions are called. It'd be best to look over the C++ source code (specifically sgp4unit.cpp) at https://www.celestrak.com/publications/AIAA/2006-6753/ and modify the call/returns of functions where necessary such that the output values are piped throughout the algorithm correctly. This was a total oversight on younger-me's part...ugh.