search

joshuaferrara / node-csgo

A node-steam plugin for Counter-Strike: Global Offensive.
MIT License
460 stars 82 forks source link

Version 1.5.13 is broken because of steam-resources #68

Closed EloB closed 4 years ago

EloB commented 4 years ago

steam-resources has a prepare script in their package.json that uses svn to clone stuff on installation.

When I try to do a fresh installation without node_modules it fails to install. Not every server has svn installed on their machines...

EloB commented 4 years ago

Version (1.5.13) should be a major version because of the steam-resources or you have to add back the node_modules folder again.

EloB commented 4 years ago

See old version https://unpkg.com/browse/csgo@1.5.12/

See new version (without node_modules) https://unpkg.com/browse/csgo@1.5.13/

joshuaferrara commented 4 years ago

Yeah, this should be handled by steam-resources being a bundled dependency, but seems like it got caught up somehow...

Will have to do a bit more research into this when time allows.

joshuaferrara commented 4 years ago

You’re doing the fresh installation with npm as opposed to cloning the repo, correct?

EloB commented 4 years ago

I've tried both yarn and npm both failed.

EloB commented 4 years ago

A workaround at the moment is to install svn locally but I think there should be a better solution.

You can manually goto the folder and run yarn prepare or npm run prepare. If you have problems with the package.

EloB commented 4 years ago

When using version 1.21.1 of yarn it never runs the prepare script. That fails everything. The files are missing and the package is broken.

When using version 6.13.4 of npm it will run the prepare script and then fails if svn doesn't exist.

Both ways it's pretty broken I would say.

EloB commented 4 years ago

I don't know how we can fix this because the owner of the library doesn't want to fix this.

https://github.com/seishun/node-steam-resources/issues/9

I managed to install on my production server at the moment but I need svn on that server too. Even if this is a dependency of a dependency. His prepare script always run no matter what. He marked my ticket as spam. So I don't think he will update it.

You have to write to the guy or add to the README that you need to have svn always installed on every device.

EloB commented 4 years ago

When do you have time to fix this? The owner of node-steam-resources claims that it will solve if the node_modules exist. This is a blocker at the moment.

joshuaferrara commented 4 years ago

No ETA. Revert to 1.5.12 if it’s causing an issue for now.

joshuaferrara commented 4 years ago

Fixed in 06ef650. I'm unsure of the circumstances, but your tone came off as quite pushy. Please try and be a bit more respectful next time. I'm sure you're aware that open source projects are typically contributed to in ones free-time, so please don't expect any type of SLA from me or others.