joshuaflanagan / serverless-ruby-package

serverless plugin to package ruby gems
39 stars 11 forks source link

Recommended package configuration of Serverless will be incompatible #29

Open svestu opened 3 years ago

svestu commented 3 years ago

Hello there,

according to a deprecation message of the current Serverless-CLI (2.33.1), the support of package.include and package.exclude will be replaced:

Deprecation warning: Support for "package.include" and "package.exclude" will be removed with next major release. Please use "package.patterns" instead

Changing the configuration like documented in https://www.serverless.com/framework/docs/providers/aws/guide/packaging/ this package throws an error:

TypeError: Cannot read property 'push' of undefined at PackageRubyBundlePlugin.beforePackage ([...]node_modules\serverless-ruby-package\index.js:85:45) at PluginManager.invoke ([...]node_modules\serverless\lib\classes\PluginManager.js:551:20)

I already took a look at the index.js. It seems that the usage of exclude and include needs to be redone. I have no idea how to do this without breaking backward compatibility.