joshuagrisham / samsung-galaxybook-extras

Samsung Galaxybook Linux platform driver and accompanying utilities.
116 stars 15 forks source link

Added screen and keyboard backlight control and toggle scripts. #26

Closed Shup04 closed 1 month ago

Shup04 commented 1 month ago

changeBacklight.sh down lowers display brightness.

changeBacklight.sh up raises display brightness.

getKeyboardBacklight.sh displays kbd backlight brightness as a percentage, regardless of it the max value is not 100.

toggleKeyboardBacklight.sh toggles the keyboard backlight between off and 100%.

These all work reliably as i have implemented them all in multiple different ways throughout my config :)

joshuagrisham commented 1 month ago

Hi @Shup04 , your interest and contribution is really appreciated! However as you might see with some of the changes we are working on (check the branch https://github.com/joshuagrisham/samsung-galaxybook-extras/tree/merge-rapgenic-driver) the plan is to try and move away from this "extra" kind of stuff and just have a platform driver that does as it should, a clean key mapping definition that handles the standard keys as they should, and leave everything else up to other userspace stuff based on everyone's preferences ( if that makes sense... :sunglasses: )

And looking a step after that, the goal will be to move this into the Linux kernel and then this repository will not even be needed after that :beers:

So based on all of that I will close this PR but please feel free to ask any question or create any issues etc with anything you find.