Some fixes on @rapgenic driver integration

[rapgenic]

Hi @joshuagrisham! As promised here is a PR of what I found while reviewing your driver.

There aren't many things to say, it works really well and it is almost on par with the windows driver!! (In some things even better)

I really found only one error, you were checking the sixth byte and not the fifth for the return value (RFLG) of the ACPI call.

Other things I did were

• Adding my Galaxy Book model to the keymap HWDB
• Adding a ACPI battery hook to expose the maximum charge threshold in the "right place", which is /sys/class/power_supply/BAT1/charge_control_end_threshold. This will allow it to pop up as a setting in the gnome settings app when https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2176 gets merged.
• Adding some static keywords to keep GCC quiet

I will be daily driving this driver for a few days, and report to you anything that will come up

P.s. I hope you don't mind, I'd like to add myself as a MODULE_AUTHOR.. It'd be a personal satisfaction to figure as one of the Linux kernel module authors :smile:

[joshuagrisham]

Hi @rapgenic I had some time today so I thought to merge in your changes and do some of the tweaks we discussed here. I will still be working in this branch "merge-rapgenic-driver" so feel absolutely free to check it later and fetch and update anything else you like and make a new PR if you have the time and want to try and tackle anything :) Super job and really cool to have you here and onboard :sunglasses: