Error when turning start on lid open ON

[seaasses]

Galaxy Book 3

• Product Name: NP750XFH-XS1BR
• Kernel: 6.8.0-31-generic (x64)
• OS: Ubuntu 24.04.1 LTS
• Driver version commit hash: https://github.com/joshuagrisham/samsung-galaxybook-extras/commit/f1aba1a7a48ec32b0a32d9eba150be998cae1b07

The sudo dmidecode --type 3 output is

Getting SMBIOS data from sysfs.
SMBIOS 3.5.0 present.

Handle 0x0003, DMI type 3, 22 bytes
Chassis Information
    Manufacturer: SAMSUNG ELECTRONICS CO., LTD.
    Type: Notebook
    Lock: Not Present
    Version: N/A
    Serial Number: ------
    Asset Tag: No Asset Tag
    Boot-up State: Safe
    Power Supply State: Safe
    Thermal State: Safe
    Security Status: None
    OEM Information: 0x00000000
    Height: Unspecified
    Number Of Power Cords: 1
    Contained Elements: 0
    SKU Number: Samsung Chassis

The issue

When running echo true | sudo tee /sys/devices/platform/samsung-galaxybook/start_on_lid_open I get the error bellow error message

tee: /sys/devices/platform/samsung-galaxybook/start_on_lid_open: Invalid argument

The error does not occur disabling the lid open option with echo false | sudo tee /sys/devices/platform/samsung-galaxybook/start_on_lid_open

Kernel Logs

[ 3293.551620] samsung_galaxybook: [DEBUG] input notification event: 0x61
[ 3378.240994] samsung_galaxybook: [DEBUG] setting start_on_lid_open
[ 3378.241001] samsung_galaxybook: [DEBUG]     43 58 7a 00 00 82 a3 80 01 00 00 00 00 00 00 00
[ 3378.241004] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[ 3378.242131] samsung_galaxybook: [DEBUG] response was:
[ 3378.242134] samsung_galaxybook: [DEBUG]     43 58 7a 00 aa ff 00 00 00 00 00 00 00 00 00 00
[ 3378.242135] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[ 3378.242137] samsung_galaxybook: invalid response when setting start_on_lid_open; returned value was: 0x00 0x00

Final comment

In fact I think the change takes place because opening the lid does turn the laptop on (I will test more), but the error message tells me that there is something to change in the codeNo, it doesn't

[seaasses]

Here is the full log when the driver is loaded

[ 3866.477959] samsung_galaxybook: loading driver
[ 3866.478174] samsung_galaxybook: [DEBUG] received following device quirks:
[ 3866.478177] samsung_galaxybook: [DEBUG]   disable_kbd_backlight       = false
[ 3866.478179] samsung_galaxybook: [DEBUG]   disable_battery_threshold   = false
[ 3866.478181] samsung_galaxybook: [DEBUG]   disable_performance_mode    = false
[ 3866.478182] samsung_galaxybook: [DEBUG]   disable_fan_speed           = false
[ 3866.478184] samsung_galaxybook: [DEBUG]   disable_i8042_filter        = false
[ 3866.478185] samsung_galaxybook: [DEBUG]   disable_acpi_hotkeys        = false
[ 3866.478187] samsung_galaxybook: [DEBUG]   disable_wmi_hotkeys         = false
[ 3866.478189] samsung_galaxybook: [DEBUG] performance_modes override exist in quirks
[ 3866.478362] samsung_galaxybook: initializing ACPI device
[ 3866.478427] samsung_galaxybook: [DEBUG] enabling ACPI feature
[ 3866.478430] samsung_galaxybook: [DEBUG]     43 58 7a 00 00 bb aa 00 00 00 00 00 00 00 00 00
[ 3866.478433] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[ 3866.479540] samsung_galaxybook: [DEBUG] response was:
[ 3866.479543] samsung_galaxybook: [DEBUG]     43 58 7a 00 aa dd cc 00 00 00 00 00 00 00 00 00
[ 3866.479546] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[ 3866.479548] samsung_galaxybook: [DEBUG] enabling ACPI feature
[ 3866.479550] samsung_galaxybook: [DEBUG]     43 58 8a 00 00 bb aa 00 00 00 00 00 00 00 00 00
[ 3866.479552] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[ 3866.480479] samsung_galaxybook: [DEBUG] response was:
[ 3866.480482] samsung_galaxybook: [DEBUG]     43 58 8a 00 aa dd cc 00 00 00 00 00 00 00 00 00
[ 3866.480484] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[ 3866.480486] samsung_galaxybook: initializing platform device
[ 3866.480574] samsung_galaxybook: initializing performance_mode
[ 3866.480576] samsung_galaxybook: [DEBUG] get supported performance modes
[ 3866.480578] samsung_galaxybook: [DEBUG]     43 58 91 00 00 8d 02 46 82 ca 8b 55 4a ba 0f 6f
[ 3866.480580] samsung_galaxybook: [DEBUG]     1e 6b 92 1b 8f 51 00 00 00 00 00 00 00 00 00 00
[ 3866.480582] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.480583] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.480585] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.480587] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.480588] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.480590] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.480591] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.480593] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.480595] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.480596] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.480598] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.480599] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.480601] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.480603] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482816] samsung_galaxybook: [DEBUG] response was:
[ 3866.482827] samsung_galaxybook: [DEBUG]     43 58 91 00 aa 8d 02 46 82 ca 8b 55 4a ba 0f 6f
[ 3866.482832] samsung_galaxybook: [DEBUG]     1e 6b 92 1b 8f 51 00 01 01 01 01 00 00 00 00 00
[ 3866.482834] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482836] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482838] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482840] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482842] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482844] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482846] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482847] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482849] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482851] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482853] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482854] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482856] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482858] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482861] samsung_galaxybook: [DEBUG] get performance mode values
[ 3866.482863] samsung_galaxybook: [DEBUG]     43 58 91 00 00 8d 02 46 82 ca 8b 55 4a ba 0f 6f
[ 3866.482865] samsung_galaxybook: [DEBUG]     1e 6b 92 1b 8f 51 01 00 00 00 00 00 00 00 00 00
[ 3866.482866] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482868] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482870] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482871] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482873] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482875] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482877] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482878] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482880] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482882] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482883] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482885] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482887] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.482889] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484795] samsung_galaxybook: [DEBUG] response was:
[ 3866.484797] samsung_galaxybook: [DEBUG]     43 58 91 00 aa 8d 02 46 82 ca 8b 55 4a ba 0f 6f
[ 3866.484798] samsung_galaxybook: [DEBUG]     1e 6b 92 1b 8f 51 01 06 00 01 02 0a 14 15 00 00
[ 3866.484800] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484801] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484802] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484803] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484804] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484805] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484806] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484807] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484808] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484809] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484810] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484811] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484812] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484813] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484814] samsung_galaxybook: will support performance_mode 'optimized' with value 0x2
[ 3866.484816] samsung_galaxybook: will support performance_mode 'quiet' with value 0xa
[ 3866.484817] samsung_galaxybook: will support performance_mode 'silent' with value 0xb
[ 3866.484818] samsung_galaxybook: will support performance_mode 'performance' with value 0x15
[ 3866.484819] samsung_galaxybook: [DEBUG] getting performance_mode
[ 3866.484820] samsung_galaxybook: [DEBUG]     43 58 91 00 00 8d 02 46 82 ca 8b 55 4a ba 0f 6f
[ 3866.484821] samsung_galaxybook: [DEBUG]     1e 6b 92 1b 8f 51 02 00 00 00 00 00 00 00 00 00
[ 3866.484823] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484824] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484825] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484826] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484827] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484828] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484829] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484830] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484831] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484832] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484833] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484834] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484834] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.484835] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.485888] samsung_galaxybook: [DEBUG] response was:
[ 3866.485890] samsung_galaxybook: [DEBUG]     43 58 91 00 aa 8d 02 46 82 ca 8b 55 4a ba 0f 6f
[ 3866.485891] samsung_galaxybook: [DEBUG]     1e 6b 92 1b 8f 51 02 0a 00 00 00 00 00 00 00 00
[ 3866.485892] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.485893] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.485894] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.485895] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.485896] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.485897] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.485898] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.485899] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.485900] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.485901] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.485902] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.485903] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.485904] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.485905] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 3866.485907] samsung_galaxybook: [DEBUG] performance_mode is currently 'quiet' (0x0a)
[ 3866.485908] samsung_galaxybook: initializing platform profile
[ 3866.485914] samsung_galaxybook: initializing kbd_backlight
[ 3866.485915] samsung_galaxybook: [DEBUG] enabling ACPI feature
[ 3866.485916] samsung_galaxybook: [DEBUG]     43 58 78 00 00 bb aa 00 00 00 00 00 00 00 00 00
[ 3866.485917] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[ 3866.487151] samsung_galaxybook: [DEBUG] response was:
[ 3866.487152] samsung_galaxybook: [DEBUG]     43 58 78 00 aa dd cc 00 00 00 00 00 00 00 00 00
[ 3866.487153] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[ 3866.487155] samsung_galaxybook: registering LED class samsung-galaxybook::kbd_backlight
[ 3866.487200] samsung_galaxybook: [DEBUG] getting kbd_backlight brightness
[ 3866.487201] samsung_galaxybook: [DEBUG]     43 58 78 00 00 81 00 00 00 00 00 00 00 00 00 00
[ 3866.487202] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[ 3866.490213] samsung_galaxybook: [DEBUG] response was:
[ 3866.490214] samsung_galaxybook: [DEBUG]     43 58 78 00 aa 00 04 00 00 00 00 00 00 00 00 00
[ 3866.490216] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[ 3866.490217] samsung_galaxybook: [DEBUG] current kbd_backlight brightness is 0
[ 3866.490219] samsung_galaxybook: initializing battery charge threshold control
[ 3866.490225] ACPI: battery: new extension: Samsung Galaxy Book Battery Extension
[ 3866.490226] samsung_galaxybook: installing i8402 key filter to capture hotkey input
[ 3866.490227] samsung_galaxybook: initializing fan speed
[ 3866.490498] samsung_galaxybook: Failed to read fan speed list
[ 3866.490502] samsung_galaxybook: Unable to get list of fan speeds
[ 3866.490503] samsung_galaxybook: initializing hwmon device
[ 3866.490532] samsung_galaxybook: enabling ACPI notifications
[ 3866.490533] samsung_galaxybook: [DEBUG] enabling ACPI feature
[ 3866.490534] samsung_galaxybook: [DEBUG]     43 58 86 00 00 bb aa 00 00 00 00 00 00 00 00 00
[ 3866.490535] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[ 3866.491224] samsung_galaxybook: [DEBUG] response was:
[ 3866.491226] samsung_galaxybook: [DEBUG]     43 58 86 00 aa dd cc 00 00 00 00 00 00 00 00 00
[ 3866.491227] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[ 3866.491228] samsung_galaxybook: [DEBUG] activate ACPI notifications
[ 3866.491230] samsung_galaxybook: [DEBUG]     43 58 86 00 00 80 02 00 00 00 00 00 00 00 00 00
[ 3866.491231] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[ 3866.493218] samsung_galaxybook: [DEBUG] response was:
[ 3866.493219] samsung_galaxybook: [DEBUG]     43 58 86 00 aa 02 00 00 00 00 00 00 00 00 00 00
[ 3866.493221] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[ 3866.493222] samsung_galaxybook: initializing hotkey input device
[ 3866.493280] input: Samsung Galaxy Book extra buttons as /devices/platform/samsung-galaxybook/input/input40
[ 3866.493348] samsung_galaxybook: enabling WMI notifications
[ 3866.493354] samsung_galaxybook: installing WMI notify handler
[ 3866.493386] samsung_galaxybook: driver successfully loaded

[joshuagrisham]

Thanks for this @seaasses ! Hrmm it seems eerily similar to the "issue" on #31 Would it be possible for you to try to build and run the previous version of the module with debug enabled and see if you get a similar payload response when setting this feature to on vs off?

Also does your laptop in fact even have this feature like when you look in Windows at the Samsung Settings app?

[joshuagrisham]

Side note: @rapgenic FYI here is a case where checking for pos 4 != 0xaa does not actually catch a failure (pos 4 == 0xaa && pos 5 == 0xff)

[joshuagrisham]

@seaasses I realized here also it would help with a copy of your DSDT .. either in this issue or #31 if you can please upload it then I think we can actually tell exactly what needs to be adjusted.

Then I will need to tweak the driver a bit to have a DMI match-based quirk maybe or at least to figure out some kind of logic to be able to steer detection of this, since it seems to be different behavior for devices that both have SAM0429 that we need to account for.

[rapgenic]

Side note: @rapgenic FYI here is a case where checking for pos 4 != 0xaa does not actually catch a failure (pos 4 == 0xaa && pos 5 == 0xff)

:fearful: I really never saw that! Do you think we should make the double check then? I still think that pos 4 is significant (it's also called RFLG which kinda sounds like return flag)

I suppose that also pos 5 == 0xff => error is correct, since no one reported to you it in the past...

[seaasses]

Thanks for this @seaasses ! Hrmm it seems eerily similar to the "issue" on #31 Would it be possible for you to try to build and run the previous version of the module with debug enabled and see if you get a similar payload response when setting this feature to on vs off?

Also does your laptop in fact even have this feature like when you look in Windows at the Samsung Settings app?

Hey, @joshuagrisham, sorry for the delay in getting back to you. Yes, actually I have similar issue with the battery saver mode too.

I'm pretty sure that the laptop have this option when using the Samsung Settings. I got the below payload using the https://github.com/joshuagrisham/samsung-galaxybook-extras/commit/5c4456980da0180fbc11ab4169ad39b2c6ceee7b version

[99132.119584] samsung_galaxybook: [DEBUG] setting start_on_lid_open
[99132.119588] samsung_galaxybook: [DEBUG]     43 58 7a 00 00 82 a3 80 00 00 00 00 00 00 00 00
[99132.119589] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[99132.120853] samsung_galaxybook: [DEBUG] response was:
[99132.120854] samsung_galaxybook: [DEBUG]     43 58 7a 00 aa 00 00 00 00 00 00 00 00 00 00 00
[99132.120855] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[99132.120856] samsung_galaxybook: [DEBUG] returned start_on_lid_open value was: 0x00 (calculated start_on_lid_open on/off as 0)
[99132.120857] samsung_galaxybook: turned start_on_lid_open off (0)
[99161.478511] samsung_galaxybook: [DEBUG] setting start_on_lid_open
[99161.478516] samsung_galaxybook: [DEBUG]     43 58 7a 00 00 82 a3 80 01 00 00 00 00 00 00 00
[99161.478517] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[99161.480184] samsung_galaxybook: [DEBUG] response was:
[99161.480187] samsung_galaxybook: [DEBUG]     43 58 7a 00 aa 00 00 01 00 00 00 00 00 00 00 00
[99161.480187] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[99161.480188] samsung_galaxybook: [DEBUG] returned start_on_lid_open value was: 0x00 (calculated start_on_lid_open on/off as 0)
[99161.480189] samsung_galaxybook: turned start_on_lid_open on (1)

I will get a copy of my DSDT and will post here soon

[seaasses]

Here is a copy of my DSDT dsdt.dsl.txt

[joshuagrisham]

Thank you @seaasses it is actually interesting that the older version is sending exactly the same payload but the command is succeeding (even though it is actually recognizing the wrong return value :face_in_clouds: ).. is it possible to give the entire full log like you did in https://github.com/joshuagrisham/samsung-galaxybook-extras/issues/32#issuecomment-2405240056, but with this older version of the driver? Wondering if maybe there is a regression in some kind of init payload or something...

Also "worst case scenario" is that I might eventually ask you for WinDbg trace plus copy of your background app in Windows, but maybe we don't need that yet for this case (like I wrote in https://github.com/joshuagrisham/samsung-galaxybook-extras/issues/31#issuecomment-2408983829) :innocent:

[seaasses]

About the other issues:

Battery saver

Version https://github.com/joshuagrisham/samsung-galaxybook-extras/commit/5c4456980da0180fbc11ab4169ad39b2c6ceee7b

[99634.445284] samsung_galaxybook: [DEBUG] setting battery_saver
[99634.445290] samsung_galaxybook: [DEBUG]     43 58 7a 00 00 82 e9 90 00 00 00 00 00 00 00 00
[99634.445291] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[99634.447733] samsung_galaxybook: [DEBUG] response was:
[99634.447735] samsung_galaxybook: [DEBUG]     43 58 7a 00 aa 00 00 00 00 00 00 00 00 00 00 00
[99634.447736] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[99634.447737] samsung_galaxybook: [DEBUG] returned battery_saver value was: 0x00 (calculated battery_saver on/off as 0)
[99634.447739] samsung_galaxybook: turned battery_saver off (0)
[99637.475061] samsung_galaxybook: [DEBUG] setting battery_saver
[99637.475065] samsung_galaxybook: [DEBUG]     43 58 7a 00 00 82 e9 90 50 00 00 00 00 00 00 00
[99637.475067] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[99637.476781] samsung_galaxybook: [DEBUG] response was:
[99637.476784] samsung_galaxybook: [DEBUG]     43 58 7a 00 aa 00 00 00 00 00 00 00 00 00 00 00
[99637.476784] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[99637.476785] samsung_galaxybook: [DEBUG] returned battery_saver value was: 0x00 (calculated battery_saver on/off as 0)
[99637.476787] samsung_galaxybook: turned battery_saver on (1)
[99654.946122] samsung_galaxybook: [DEBUG] getting battery_saver
[99654.946127] samsung_galaxybook: [DEBUG]     43 58 7a 00 00 82 e9 91 00 00 00 00 00 00 00 00
[99654.946128] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[99654.947784] samsung_galaxybook: [DEBUG] response was:
[99654.947786] samsung_galaxybook: [DEBUG]     43 58 7a 00 aa 00 00 50 00 00 00 00 00 00 00 00
[99654.947787] samsung_galaxybook: [DEBUG]     00 00 00 00 00

Newer version

Trying to set to 80 (failed) and 0.

[100509.903720] samsung_galaxybook: [DEBUG] getting battery charge_control_end_threshold
[100509.903725] samsung_galaxybook: [DEBUG]     43 58 7a 00 00 82 e9 91 00 00 00 00 00 00 00 00
[100509.903726] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[100509.905310] samsung_galaxybook: [DEBUG] response was:
[100509.905312] samsung_galaxybook: [DEBUG]     43 58 7a 00 aa 00 00 50 00 00 00 00 00 00 00 00
[100509.905313] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[100509.905314] samsung_galaxybook: [DEBUG] battery charge control is currently on; battery charge_control_end_threshold is 80
[100517.503423] samsung_galaxybook: [DEBUG] setting battery charge_control_end_threshold
[100517.503429] samsung_galaxybook: [DEBUG]     43 58 7a 00 00 82 e9 90 50 00 00 00 00 00 00 00
[100517.503430] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[100517.506024] samsung_galaxybook: [DEBUG] response was:
[100517.506027] samsung_galaxybook: [DEBUG]     43 58 7a 00 aa 00 00 00 00 00 00 00 00 00 00 00
[100517.506028] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[100517.506029] samsung_galaxybook: invalid response when setting charge_control_end_threshold; returned value was: 0x00 0x00
[100526.503368] samsung_galaxybook: [DEBUG] setting battery charge_control_end_threshold
[100526.503373] samsung_galaxybook: [DEBUG]     43 58 7a 00 00 82 e9 90 00 00 00 00 00 00 00 00
[100526.503374] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[100526.505267] samsung_galaxybook: [DEBUG] response was:
[100526.505269] samsung_galaxybook: [DEBUG]     43 58 7a 00 aa 00 00 00 00 00 00 00 00 00 00 00
[100526.505270] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[100526.505271] samsung_galaxybook: set battery charge_control_end_threshold to 0

USB Charging mode

Actually I don't know if my laptop support this, but here are the logs.

Version https://github.com/joshuagrisham/samsung-galaxybook-extras/commit/5c4456980da0180fbc11ab4169ad39b2c6ceee7b

[99862.141481] samsung_galaxybook: [DEBUG] getting usb_charging
[99862.141487] samsung_galaxybook: [DEBUG]     43 58 67 00 00 80 00 00 00 00 00 00 00 00 00 00
[99862.141488] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[99862.142233] samsung_galaxybook: failed to get response from getting usb_charging; failure code 0xff was reported from the device
[99862.142237] samsung_galaxybook: [DEBUG] response was:
[99862.142238] samsung_galaxybook: [DEBUG]     43 58 67 00 aa ff 00 00 00 00 00 00 00 00 00 00
[99862.142239] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[99867.528036] samsung_galaxybook: [DEBUG] setting usb_charging
[99867.528041] samsung_galaxybook: [DEBUG]     43 58 68 00 00 81 00 00 00 00 00 00 00 00 00 00
[99867.528043] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[99867.528760] samsung_galaxybook: failed to get response from setting usb_charging; failure code 0xff was reported from the device
[99867.528764] samsung_galaxybook: [DEBUG] response was:
[99867.528765] samsung_galaxybook: [DEBUG]     43 58 68 00 aa ff 00 00 00 00 00 00 00 00 00 00
[99867.528766] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[99873.937066] samsung_galaxybook: [DEBUG] setting usb_charging
[99873.937071] samsung_galaxybook: [DEBUG]     43 58 68 00 00 80 00 00 00 00 00 00 00 00 00 00
[99873.937073] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[99873.937787] samsung_galaxybook: failed to get response from setting usb_charging; failure code 0xff was reported from the device
[99873.937791] samsung_galaxybook: [DEBUG] response was:
[99873.937793] samsung_galaxybook: [DEBUG]     43 58 68 00 aa ff 00 00 00 00 00 00 00 00 00 00
[99873.937794] samsung_galaxybook: [DEBUG]     00 00 00 00 00

Newer version

[100685.255143] samsung_galaxybook: [DEBUG] getting usb_charge
[100685.255148] samsung_galaxybook: [DEBUG]     43 58 67 00 00 80 00 00 00 00 00 00 00 00 00 00
[100685.255149] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[100685.255870] samsung_galaxybook: [DEBUG] response was:
[100685.255872] samsung_galaxybook: [DEBUG]     43 58 67 00 aa ff 00 00 00 00 00 00 00 00 00 00
[100685.255872] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[100685.255873] samsung_galaxybook: [DEBUG] usb_charge is currently on (1)
[100690.936651] samsung_galaxybook: [DEBUG] setting usb_charge
[100690.936653] samsung_galaxybook: [DEBUG]     43 58 68 00 00 81 00 00 00 00 00 00 00 00 00 00
[100690.936654] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[100690.937203] samsung_galaxybook: [DEBUG] response was:
[100690.937203] samsung_galaxybook: [DEBUG]     43 58 68 00 aa ff 00 00 00 00 00 00 00 00 00 00
[100690.937204] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[100690.937205] samsung_galaxybook: invalid response when setting usb_charge; returned value was: 0xff
[100697.408200] samsung_galaxybook: [DEBUG] setting usb_charge
[100697.408205] samsung_galaxybook: [DEBUG]     43 58 68 00 00 80 00 00 00 00 00 00 00 00 00 00
[100697.408207] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[100697.409076] samsung_galaxybook: [DEBUG] response was:
[100697.409079] samsung_galaxybook: [DEBUG]     43 58 68 00 aa ff 00 00 00 00 00 00 00 00 00 00
[100697.409080] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[100697.409082] samsung_galaxybook: invalid response when setting usb_charge; returned value was: 0xff

[joshuagrisham]

Note to myself: need to also look into this compared to what is available for the fan device in the DSDT .. :)

[ 3866.490498] samsung_galaxybook: Failed to read fan speed list
[ 3866.490502] samsung_galaxybook: Unable to get list of fan speeds

[seaasses]

Thank you @seaasses it is actually interesting that the older version is sending exactly the same payload but the command is succeeding (even though it is actually recognizing the wrong return value 😶‍🌫️ ).. is it possible to give the entire full log like you did in #32 (comment), but with this older version of the driver? Wondering if maybe there is a regression in some kind of init payload or something...

Also "worst case scenario" is that I might eventually ask you for WinDbg trace plus copy of your background app in Windows, but maybe we don't need that yet for this case (like I wrote in #31 (comment)) 😇

Yes, of course, here is the full log

[101288.072356] samsung_galaxybook: loading driver
[101288.072557] samsung_galaxybook: initializing ACPI device
[101288.072559] samsung_galaxybook: [DEBUG] initializing 0x7a controls
[101288.072560] samsung_galaxybook: [DEBUG]     43 58 7a 00 00 bb aa 00 00 00 00 00 00 00 00 00
[101288.072561] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[101288.073416] samsung_galaxybook: [DEBUG] response was:
[101288.073418] samsung_galaxybook: [DEBUG]     43 58 7a 00 aa dd cc 00 00 00 00 00 00 00 00 00
[101288.073419] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[101288.073420] samsung_galaxybook: device controls successfully initialized via ACPI method CSFI
[101288.073421] samsung_galaxybook: initializing platform device
[101288.073471] samsung_galaxybook: initializing performance_mode
[101288.073472] samsung_galaxybook: [DEBUG] initializing performance_mode control step 1
[101288.073473] samsung_galaxybook: [DEBUG]     43 58 91 00 00 8d 02 46 82 ca 8b 55 4a ba 0f 6f
[101288.073474] samsung_galaxybook: [DEBUG]     1e 6b 92 1b 8f 51 01 00 00 00 00 00 00 00 00 00
[101288.073475] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.073476] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.073477] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.073478] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.073478] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.073479] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.073480] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.073481] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.073482] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.073482] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.073483] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.073484] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.073485] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.073485] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074490] samsung_galaxybook: [DEBUG] response was:
[101288.074492] samsung_galaxybook: [DEBUG]     43 58 91 00 aa 8d 02 46 82 ca 8b 55 4a ba 0f 6f
[101288.074493] samsung_galaxybook: [DEBUG]     1e 6b 92 1b 8f 51 01 06 00 01 02 0a 14 15 00 00
[101288.074493] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074494] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074495] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074495] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074496] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074497] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074497] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074504] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074504] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074505] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074506] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074507] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074508] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074508] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074509] samsung_galaxybook: [DEBUG] initializing performance_mode control step 2
[101288.074510] samsung_galaxybook: [DEBUG]     43 58 91 00 00 8d 02 46 82 ca 8b 55 4a ba 0f 6f
[101288.074511] samsung_galaxybook: [DEBUG]     1e 6b 92 1b 8f 51 00 00 00 00 00 00 00 00 00 00
[101288.074512] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074513] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074514] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074514] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074515] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074516] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074517] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074517] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074518] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074519] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074520] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074520] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074521] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.074522] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075286] samsung_galaxybook: [DEBUG] response was:
[101288.075287] samsung_galaxybook: [DEBUG]     43 58 91 00 aa 8d 02 46 82 ca 8b 55 4a ba 0f 6f
[101288.075288] samsung_galaxybook: [DEBUG]     1e 6b 92 1b 8f 51 00 01 01 01 01 00 00 00 00 00
[101288.075288] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075289] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075290] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075290] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075291] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075291] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075292] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075293] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075293] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075294] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075295] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075295] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075296] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075297] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075297] samsung_galaxybook: performance_mode control successfully initialized via ACPI method CSXI
[101288.075298] samsung_galaxybook: [DEBUG] setting initial performance_mode
[101288.075299] samsung_galaxybook: [DEBUG]     43 58 91 00 00 8d 02 46 82 ca 8b 55 4a ba 0f 6f
[101288.075299] samsung_galaxybook: [DEBUG]     1e 6b 92 1b 8f 51 03 02 00 00 00 00 00 00 00 00
[101288.075300] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075301] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075301] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075302] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075303] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075303] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075304] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075304] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075305] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075306] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075306] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075307] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075308] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.075308] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.279099] samsung_galaxybook: [DEBUG] response was:
[101288.279103] samsung_galaxybook: [DEBUG]     43 58 91 00 aa 8d 02 46 82 ca 8b 55 4a ba 0f 6f
[101288.279104] samsung_galaxybook: [DEBUG]     1e 6b 92 1b 8f 51 03 00 00 00 00 00 00 00 00 00
[101288.279105] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.279106] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.279107] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.279107] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.279108] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.279108] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.279109] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.279110] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.279110] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.279111] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.279112] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.279112] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.279113] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.279113] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[101288.279114] samsung_galaxybook: performance_mode initialized with startup value of 'optimized'
[101288.279116] samsung_galaxybook: initializing platform profile
[101288.279122] samsung_galaxybook: initializing kbd_backlight
[101288.279123] samsung_galaxybook: [DEBUG] initializing kbd_backlight brightness
[101288.279123] samsung_galaxybook: [DEBUG]     43 58 78 00 00 bb aa 00 00 00 00 00 00 00 00 00
[101288.279124] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[101288.280796] samsung_galaxybook: [DEBUG] response was:
[101288.280798] samsung_galaxybook: [DEBUG]     43 58 78 00 aa dd cc 00 00 00 00 00 00 00 00 00
[101288.280799] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[101288.280799] samsung_galaxybook: kbd_backlight successfully initialized via ACPI method CSFI
[101288.280800] samsung_galaxybook: registering LED class samsung-galaxybook::kbd_backlight
[101288.280859] samsung_galaxybook: installing i8402 key filter to capture hotkey input
[101288.280860] samsung_galaxybook: initializing fan speed
[101288.280874] samsung_galaxybook: Failed to read fan speed list
[101288.280876] samsung_galaxybook: Unable to get list of fan speeds
[101288.280877] samsung_galaxybook: initializing hwmon device
[101288.280895] samsung_galaxybook: enabling ACPI notifications
[101288.280896] samsung_galaxybook: [DEBUG] step 1 to enable ACPI notifications (initializing 0x86 controls)
[101288.280897] samsung_galaxybook: [DEBUG]     43 58 86 00 00 bb aa 00 00 00 00 00 00 00 00 00
[101288.280898] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[101288.281675] samsung_galaxybook: [DEBUG] response was:
[101288.281676] samsung_galaxybook: [DEBUG]     43 58 86 00 aa dd cc 00 00 00 00 00 00 00 00 00
[101288.281677] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[101288.281678] samsung_galaxybook: [DEBUG] step 2 to enable ACPI notifications (enable)
[101288.281679] samsung_galaxybook: [DEBUG]     43 58 86 00 00 80 02 00 00 00 00 00 00 00 00 00
[101288.281680] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[101288.283787] samsung_galaxybook: [DEBUG] response was:
[101288.283788] samsung_galaxybook: [DEBUG]     43 58 86 00 aa 02 00 00 00 00 00 00 00 00 00 00
[101288.283789] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[101288.283796] samsung_galaxybook: ACPI notifications successfully enabled via ACPI methods SDLS and CSFI
[101288.283797] samsung_galaxybook: initializing hotkey input device
[101288.283837] input: Samsung Galaxybook extra buttons as /devices/platform/samsung-galaxybook/input/input51
[101288.283945] samsung_galaxybook: enabling WMI notifications
[101288.283951] samsung_galaxybook: installing WMI notify handler
[101288.283983] samsung_galaxybook: driver successfully loaded

[seaasses]

Also "worst case scenario" is that I might eventually ask you for WinDbg trace plus copy of your background app in Windows, but maybe we don't need that yet for this case (like I wrote in #31 (comment)) 😇

Based on what you said in #31 (comment) it seems that the WinDbg trace will be required. I completely removed Windows, but will reinstall in dual boot to get these.

[seaasses]

Hey @joshuagrisham, one of my usb c ports stopped working and I can not charge the laptop with it anymore. When I plug the cable, the charging sound is emitted, but it don't charge even with 20% battery. Maybe it is something with the battery saver mode, I will investigate more. And This night I will install Windows and get the logs you asked for

[joshuagrisham]

Hi @seaasses wow sorry to hear about your USB port :( but hopefully it will be ok!! Please let me know if it seems like it could have been caused by the driver or something else strange (thought I would hope not as this should be protected by Samsung's ACPI I think....)

Anyway in the meantime I have tried to read through some differences and making a "best guess" here at something that might could be contributing to the problem.. can you please try the branch here and see if it fixes this problem for you?

https://github.com/joshuagrisham/samsung-galaxybook-extras/tree/issue-32-error-when-turning-start-on-lid-open-on

[joshuagrisham]

@seaasses also took a quick look at your DSDT regarding the fan speed... your device seems to have 2 ACPI fan devices instead of 1 ("CPU Fan" and "GPU Fan") and the _FST method looks a bit different than mine.. maybe it actually works? :wink:

If you set the module parameter fan_speed=off and then after the module is loaded, check either sudo sensors or see if there are any devices under /sys/bus/acpi/devices/PNP0C0B* with an attribute fan_speed_rpm, do they have any value?

If so then I can add as a quirk for SAM0429 to disable fan_speed workaround/implementation from this driver :)

[joshuagrisham]

Regarding battery saver, I noticed a small tweak that was needed and pushed a change to the same branch.. wondering if you can try the latest in https://github.com/joshuagrisham/samsung-galaxybook-extras/tree/issue-32-error-when-turning-start-on-lid-open-on and see if you still have any issues? :innocent:

Regarding "usb charge" mode, yes it would be interesting to see what you have in Windows for this.. the old version of this driver also seemed to fail on your device?

[seaasses]

Anyway in the meantime I have tried to read through some differences and making a "best guess" here at something that might could be contributing to the problem.. can you please try the branch here and see if it fixes this problem for you?

Hey, Joshua, I tested the branch issue-32-error-when-turning-start-on-lid-open-on and got errors. Here are the logs when the driver is loaded:

[  825.303099] samsung_galaxybook: loading driver
[  825.303529] samsung_galaxybook: initializing ACPI device
[  825.303620] samsung_galaxybook: initializing ACPI power management features
[  825.303623] samsung_galaxybook: [DEBUG] enabling ACPI feature
[  825.303628] samsung_galaxybook: [DEBUG]     43 58 7a 00 00 bb aa 00 00 00 00 00 00 00 00 00
[  825.303632] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[  825.304776] samsung_galaxybook: [DEBUG] response was:
[  825.304782] samsung_galaxybook: [DEBUG]     43 58 7a 00 aa dd cc 00 00 00 00 00 00 00 00 00
[  825.304785] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[  825.304788] samsung_galaxybook: initializing platform device
[  825.304943] samsung_galaxybook: initializing performance mode and platform profile
[  825.304947] samsung_galaxybook: [DEBUG] get supported performance modes
[  825.304951] samsung_galaxybook: [DEBUG]     43 58 91 00 00 8d 02 46 82 ca 8b 55 4a ba 0f 6f
[  825.304953] samsung_galaxybook: [DEBUG]     1e 6b 92 1b 8f 51 01 00 00 00 00 00 00 00 00 00
[  825.304956] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.304958] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.304960] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.304962] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.304965] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.304967] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.304969] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.304972] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.304974] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.304976] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.304978] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.304980] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.304983] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.304985] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307785] samsung_galaxybook: [DEBUG] response was:
[  825.307790] samsung_galaxybook: [DEBUG]     43 58 91 00 aa 8d 02 46 82 ca 8b 55 4a ba 0f 6f
[  825.307792] samsung_galaxybook: [DEBUG]     1e 6b 92 1b 8f 51 01 06 00 01 02 0a 14 15 00 00
[  825.307794] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307795] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307797] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307799] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307800] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307802] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307804] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307805] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307807] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307809] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307810] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307812] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307813] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307815] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307818] samsung_galaxybook: will support profile 'performance' with performance mode value 0x15
[  825.307823] samsung_galaxybook: unmapped performance mode value 0x14 will be ignored
[  825.307825] samsung_galaxybook: will support profile 'low-power' with performance mode value 0xa
[  825.307827] samsung_galaxybook: will support profile 'balanced' with performance mode value 0x2
[  825.307829] samsung_galaxybook: unmapped performance mode value 0x1 will be ignored
[  825.307831] samsung_galaxybook: unmapped performance mode value 0x0 will be ignored
[  825.307838] samsung_galaxybook: [DEBUG] getting performance_mode
[  825.307840] samsung_galaxybook: [DEBUG]     43 58 91 00 00 8d 02 46 82 ca 8b 55 4a ba 0f 6f
[  825.307842] samsung_galaxybook: [DEBUG]     1e 6b 92 1b 8f 51 02 00 00 00 00 00 00 00 00 00
[  825.307844] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307846] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307847] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307849] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307851] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307852] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307854] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307856] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307857] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307859] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307861] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307862] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307864] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.307865] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.309987] samsung_galaxybook: [DEBUG] response was:
[  825.309990] samsung_galaxybook: [DEBUG]     43 58 91 00 aa 8d 02 46 82 ca 8b 55 4a ba 0f 6f
[  825.309992] samsung_galaxybook: [DEBUG]     1e 6b 92 1b 8f 51 02 02 00 00 00 00 00 00 00 00
[  825.309994] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.309996] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.309998] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.310000] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.310002] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.310004] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.310006] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.310008] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.310009] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.310011] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.310013] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.310015] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.310017] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.310019] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[  825.310021] samsung_galaxybook: initializing kbd_backlight
[  825.310040] samsung_galaxybook: [DEBUG] enabling ACPI feature
[  825.310043] samsung_galaxybook: [DEBUG]     43 58 78 00 00 bb aa 00 00 00 00 00 00 00 00 00
[  825.310047] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[  825.311808] samsung_galaxybook: [DEBUG] response was:
[  825.311811] samsung_galaxybook: [DEBUG]     43 58 78 00 aa dd cc 00 00 00 00 00 00 00 00 00
[  825.311813] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[  825.311817] samsung_galaxybook: registering LED class samsung-galaxybook::kbd_backlight
[  825.311917] samsung_galaxybook: [DEBUG] getting kbd_backlight brightness
[  825.311919] samsung_galaxybook: [DEBUG]     43 58 78 00 00 81 00 00 00 00 00 00 00 00 00 00
[  825.311921] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[  825.314811] samsung_galaxybook: [DEBUG] response was:
[  825.314815] samsung_galaxybook: [DEBUG]     43 58 78 00 aa 00 04 00 00 00 00 00 00 00 00 00
[  825.314817] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[  825.314819] samsung_galaxybook: [DEBUG] current kbd_backlight brightness is 0
[  825.314823] samsung_galaxybook: initializing battery charge threshold control
[  825.314837] ACPI: battery: new extension: Samsung Galaxy Book Battery Extension
[  825.314840] samsung_galaxybook: initializing ACPI allow_recording feature
[  825.314842] samsung_galaxybook: [DEBUG] enabling ACPI feature
[  825.314844] samsung_galaxybook: [DEBUG]     43 58 8a 00 00 bb aa 00 00 00 00 00 00 00 00 00
[  825.314846] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[  825.316245] samsung_galaxybook: [DEBUG] response was:
[  825.316248] samsung_galaxybook: [DEBUG]     43 58 8a 00 aa dd cc 00 00 00 00 00 00 00 00 00
[  825.316250] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[  825.316252] samsung_galaxybook: installing i8402 key filter to capture hotkey input
[  825.316255] samsung_galaxybook: initializing fan speed
[  825.316292] samsung_galaxybook: Failed to read fan speed list
[  825.316299] samsung_galaxybook: Unable to get list of fan speeds
[  825.316301] samsung_galaxybook: initializing hwmon device
[  825.316362] samsung_galaxybook: enabling ACPI notifications
[  825.316364] samsung_galaxybook: [DEBUG] enabling ACPI feature
[  825.316366] samsung_galaxybook: [DEBUG]     43 58 86 00 00 bb aa 00 00 00 00 00 00 00 00 00
[  825.316368] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[  825.317405] samsung_galaxybook: [DEBUG] response was:
[  825.317409] samsung_galaxybook: [DEBUG]     43 58 86 00 aa dd cc 00 00 00 00 00 00 00 00 00
[  825.317411] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[  825.317413] samsung_galaxybook: [DEBUG] activate ACPI notifications
[  825.317416] samsung_galaxybook: [DEBUG]     43 58 86 00 00 80 02 00 00 00 00 00 00 00 00 00
[  825.317418] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[  825.318805] samsung_galaxybook: [DEBUG] response was:
[  825.318808] samsung_galaxybook: [DEBUG]     43 58 86 00 aa 02 00 00 00 00 00 00 00 00 00 00
[  825.318810] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[  825.318812] samsung_galaxybook: initializing hotkey input device
[  825.318907] input: Samsung Galaxy Book extra buttons as /devices/platform/samsung-galaxybook/input/input30
[  825.319050] samsung_galaxybook: enabling WMI notifications
[  825.319067] samsung_galaxybook: installing WMI notify handler
[  825.319138] samsung_galaxybook: driver successfully loaded

And the logs when I cycle through the options:

[ 1693.886727] samsung_galaxybook: [DEBUG] getting start_on_lid_open
[ 1693.886738] samsung_galaxybook: [DEBUG]     43 58 7a 00 00 82 a3 81 00 00 00 00 00 00 00 00
[ 1693.886740] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[ 1693.889149] samsung_galaxybook: [DEBUG] response was:
[ 1693.889153] samsung_galaxybook: [DEBUG]     43 58 7a 00 aa 00 00 01 00 00 00 00 00 00 00 00
[ 1693.889155] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[ 1693.889157] samsung_galaxybook: [DEBUG] start_on_lid_open is currently on (1)
[ 1700.568856] samsung_galaxybook: [DEBUG] setting start_on_lid_open
[ 1700.568868] samsung_galaxybook: [DEBUG]     43 58 7a 00 00 82 a3 80 01 00 00 00 00 00 00 00
[ 1700.568871] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[ 1700.571378] samsung_galaxybook: [DEBUG] response was:
[ 1700.571384] samsung_galaxybook: [DEBUG]     43 58 7a 00 aa 00 00 01 00 00 00 00 00 00 00 00
[ 1700.571387] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[ 1700.571389] samsung_galaxybook: invalid response when setting start_on_lid_open; returned value was: 0x01 0x00
[ 1707.070542] samsung_galaxybook: [DEBUG] setting start_on_lid_open
[ 1707.070554] samsung_galaxybook: [DEBUG]     43 58 7a 00 00 82 a3 80 00 00 00 00 00 00 00 00
[ 1707.070557] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[ 1707.073207] samsung_galaxybook: [DEBUG] response was:
[ 1707.073213] samsung_galaxybook: [DEBUG]     43 58 7a 00 aa 00 00 00 00 00 00 00 00 00 00 00
[ 1707.073215] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[ 1707.073218] samsung_galaxybook: turned start_on_lid_open off (0)
[ 1714.680011] samsung_galaxybook: [DEBUG] setting start_on_lid_open
[ 1714.680023] samsung_galaxybook: [DEBUG]     43 58 7a 00 00 82 a3 80 01 00 00 00 00 00 00 00
[ 1714.680025] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[ 1714.682448] samsung_galaxybook: [DEBUG] response was:
[ 1714.682453] samsung_galaxybook: [DEBUG]     43 58 7a 00 aa 00 00 01 00 00 00 00 00 00 00 00
[ 1714.682455] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[ 1714.682457] samsung_galaxybook: invalid response when setting start_on_lid_open; returned value was: 0x01 0x00
[ 1722.838681] samsung_galaxybook: [DEBUG] getting start_on_lid_open
[ 1722.838692] samsung_galaxybook: [DEBUG]     43 58 7a 00 00 82 a3 81 00 00 00 00 00 00 00 00
[ 1722.838694] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[ 1722.840696] samsung_galaxybook: [DEBUG] response was:
[ 1722.840703] samsung_galaxybook: [DEBUG]     43 58 7a 00 aa 00 00 01 00 00 00 00 00 00 00 00
[ 1722.840705] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[ 1722.840707] samsung_galaxybook: [DEBUG] start_on_lid_open is currently on (1)

And about the fans, my sudo sensors output after reloading the driver with fan_speed=off is:

ucsi_source_psy_USBC000:002-isa-0000
Adapter: ISA adapter
in0:           0.00 V  (min =  +0.00 V, max =  +0.00 V)
curr1:         0.00 A  (max =  +0.00 A)

i915-pci-0300
Adapter: PCI adapter
in0:         640.00 mV 
power1:           N/A  (max =  40.00 W)
energy1:       2.60 kJ

coretemp-isa-0000
Adapter: ISA adapter
Package id 0:  +47.0°C  (high = +100.0°C, crit = +100.0°C)
Core 0:        +42.0°C  (high = +100.0°C, crit = +100.0°C)
Core 4:        +40.0°C  (high = +100.0°C, crit = +100.0°C)
Core 8:        +41.0°C  (high = +100.0°C, crit = +100.0°C)
Core 12:       +40.0°C  (high = +100.0°C, crit = +100.0°C)
Core 16:       +46.0°C  (high = +100.0°C, crit = +100.0°C)
Core 17:       +46.0°C  (high = +100.0°C, crit = +100.0°C)
Core 18:       +46.0°C  (high = +100.0°C, crit = +100.0°C)
Core 19:       +46.0°C  (high = +100.0°C, crit = +100.0°C)
Core 20:       +46.0°C  (high = +100.0°C, crit = +100.0°C)
Core 21:       +46.0°C  (high = +100.0°C, crit = +100.0°C)
Core 22:       +46.0°C  (high = +100.0°C, crit = +100.0°C)
Core 23:       +46.0°C  (high = +100.0°C, crit = +100.0°C)

nvme-pci-0400
Adapter: PCI adapter
Composite:    +26.9°C  (low  = -273.1°C, high = +82.8°C)
                       (crit = +84.8°C)
Sensor 1:     +26.9°C  (low  = -273.1°C, high = +65261.8°C)

ucsi_source_psy_USBC000:001-isa-0000
Adapter: ISA adapter
in0:           5.00 V  (min =  +5.00 V, max =  +5.00 V)
curr1:         0.00 A  (max =  +3.00 A)

iwlwifi_1-virtual-0
Adapter: Virtual device
temp1:        +38.0°C  

BAT1-acpi-0
Adapter: ACPI interface
in0:          14.89 V  
curr1:       917.00 mA 

It seems that there isn't a fan_speed_rpm

And I have a question, why do the performance mode hotkeys requires kernel 6.10 or later? [ 3596.479728] samsung_galaxybook: performance mode hotkey requires kernel version 6.10 or higher

[joshuagrisham]

Hi @seaasses , now hopefully we are getting somewhere :) Can you please try again, I have updated the branch with additional tweaks.

More info if you are curious: For other devices we were checking the response from the "set" command but it looks like your device does not follow the exact same API for these methods. In theory as long as we are checking for the success (0xaa) and lack of failure code (0xff) in the responses (which we are doing for all method calls) then it should work and we do not need to do these extra steps (they are overkill.. as you might see yourself in the log the setting was actually holding it was just spitting this error anyway..)

hotkey support in 6.10+ only

Regarding question on hotkey, well.. it was because in 6.10 they added this function that takes care of the cycle for you (platform_profile_cycle)... otherwise the logic is kind of complicated, and instead of building my own custom logic, I decided to use that new function to take care of this toggling. Anyway if/when we try to get this submitted for mainline, I will even take away the print from the log like you pasted and it will ONLY work with the version of the kernel from that point and moving forward 6.12+ depending on when we can get all of these issues ironed out and hopefully submit a patch to mainline :)

I tested with 6.11.3 and it works quite well. Also, a nice bonus with 6.11.3 is that your speakers will start working (as long as your device is in the quirk table of patch_realtek.c) :wink: :sunglasses:

fan speed

Regarding the fan speed, hrmm that is a bummer... If you want, can you check the _FST method for both of your fans and see if it works on your device or not? Try to run these commands and post back the results if you like:

sudo modprobe acpi_call

# get result of FAN1 _FST
echo '\_SB.PC00.LPCB.H_EC.FAN1._FST' | sudo tee /proc/acpi/call && sudo cat /proc/acpi/call

# get result of FAN2 _FST
echo '\_SB.PC00.LPCB.H_EC.FAN2._FST' | sudo tee /proc/acpi/call && sudo cat /proc/acpi/call

On my device (GB2 Pro) the _FST method has a bug and I get an ACPI exception when I try to run it (and loads of spam in the kernel log).. the same exception even happens in Windows and there is a lot of spam with ACPI exceptions when you are debugging the kernel... So I sort of reverse-engineered what I saw in the DSDT to try and figure out what it was "supposed" to do, and then implemented that in this Linux driver, instead.

It would be way easier if your device could just directly use the standard _FST methods without having to hack together a solution... though I do see similar "fan speed tables" in your DSDT, but it looks a bit more complicated (there are 3 different tables instead of just 1, and it looks like it looks at each different table based on different conditions... so a bit more work would need to be done to figure out exactly what is happening there....)

[seaasses]

Can you please try again, I have updated the branch with additional tweaks.

Now I got:

[13210.042913] samsung_galaxybook: loading driver
[13210.043469] samsung_galaxybook: initializing ACPI device
[13210.043558] samsung_galaxybook: initializing ACPI power management features
[13210.043562] samsung_galaxybook: [DEBUG] enabling ACPI feature
[13210.043567] samsung_galaxybook: [DEBUG]     43 58 7a 00 00 bb aa 00 00 00 00 00 00 00 00 00
[13210.043571] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[13210.045342] samsung_galaxybook: [DEBUG] response was:
[13210.045353] samsung_galaxybook: [DEBUG]     43 58 7a 00 aa dd cc 00 00 00 00 00 00 00 00 00
[13210.045356] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[13210.045360] samsung_galaxybook: initializing platform device
[13210.045538] samsung_galaxybook: initializing performance mode and platform profile
[13210.045541] samsung_galaxybook: [DEBUG] get supported performance modes
[13210.045544] samsung_galaxybook: [DEBUG]     43 58 91 00 00 8d 02 46 82 ca 8b 55 4a ba 0f 6f
[13210.045547] samsung_galaxybook: [DEBUG]     1e 6b 92 1b 8f 51 01 00 00 00 00 00 00 00 00 00
[13210.045549] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.045551] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.045553] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.045555] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.045557] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.045559] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.045561] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.045563] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.045565] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.045567] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.045569] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.045572] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.045574] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.045576] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049005] samsung_galaxybook: [DEBUG] response was:
[13210.049009] samsung_galaxybook: [DEBUG]     43 58 91 00 aa 8d 02 46 82 ca 8b 55 4a ba 0f 6f
[13210.049011] samsung_galaxybook: [DEBUG]     1e 6b 92 1b 8f 51 01 06 00 01 02 0a 14 15 00 00
[13210.049014] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049016] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049018] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049020] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049023] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049025] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049027] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049029] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049031] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049033] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049035] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049037] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049039] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049041] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049044] samsung_galaxybook: will support profile 'performance' with performance mode value 0x15
[13210.049048] samsung_galaxybook: unmapped performance mode value 0x14 will be ignored
[13210.049051] samsung_galaxybook: will support profile 'low-power' with performance mode value 0xa
[13210.049054] samsung_galaxybook: will support profile 'balanced' with performance mode value 0x2
[13210.049057] samsung_galaxybook: unmapped performance mode value 0x1 will be ignored
[13210.049059] samsung_galaxybook: unmapped performance mode value 0x0 will be ignored
[13210.049067] samsung_galaxybook: [DEBUG] getting performance_mode
[13210.049070] samsung_galaxybook: [DEBUG]     43 58 91 00 00 8d 02 46 82 ca 8b 55 4a ba 0f 6f
[13210.049072] samsung_galaxybook: [DEBUG]     1e 6b 92 1b 8f 51 02 00 00 00 00 00 00 00 00 00
[13210.049074] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049076] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049078] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049080] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049082] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049084] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049086] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049088] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049090] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049092] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049094] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049096] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049098] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.049100] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.051347] samsung_galaxybook: [DEBUG] response was:
[13210.051351] samsung_galaxybook: [DEBUG]     43 58 91 00 aa 8d 02 46 82 ca 8b 55 4a ba 0f 6f
[13210.051353] samsung_galaxybook: [DEBUG]     1e 6b 92 1b 8f 51 02 02 00 00 00 00 00 00 00 00
[13210.051355] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.051357] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.051359] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.051361] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.051363] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.051365] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.051367] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.051369] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.051370] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.051372] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.051374] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.051376] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.051378] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.051380] samsung_galaxybook: [DEBUG]     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[13210.051382] samsung_galaxybook: initializing kbd_backlight
[13210.051384] samsung_galaxybook: [DEBUG] enabling ACPI feature
[13210.051385] samsung_galaxybook: [DEBUG]     43 58 78 00 00 bb aa 00 00 00 00 00 00 00 00 00
[13210.051387] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[13210.053870] samsung_galaxybook: [DEBUG] response was:
[13210.053873] samsung_galaxybook: [DEBUG]     43 58 78 00 aa dd cc 00 00 00 00 00 00 00 00 00
[13210.053875] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[13210.053878] samsung_galaxybook: registering LED class samsung-galaxybook::kbd_backlight
[13210.053959] samsung_galaxybook: [DEBUG] getting kbd_backlight brightness
[13210.053962] samsung_galaxybook: [DEBUG]     43 58 78 00 00 81 00 00 00 00 00 00 00 00 00 00
[13210.053964] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[13210.056880] samsung_galaxybook: [DEBUG] response was:
[13210.056885] samsung_galaxybook: [DEBUG]     43 58 78 00 aa 00 04 00 00 00 00 00 00 00 00 00
[13210.056889] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[13210.056892] samsung_galaxybook: [DEBUG] current kbd_backlight brightness is 0
[13210.056897] samsung_galaxybook: initializing battery charge threshold control
[13210.056915] ACPI: battery: new extension: Samsung Galaxy Book Battery Extension
[13210.056919] samsung_galaxybook: initializing ACPI allow_recording feature
[13210.056921] samsung_galaxybook: [DEBUG] enabling ACPI feature
[13210.056923] samsung_galaxybook: [DEBUG]     43 58 8a 00 00 bb aa 00 00 00 00 00 00 00 00 00
[13210.056925] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[13210.058521] samsung_galaxybook: [DEBUG] response was:
[13210.058526] samsung_galaxybook: [DEBUG]     43 58 8a 00 aa dd cc 00 00 00 00 00 00 00 00 00
[13210.058528] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[13210.058530] samsung_galaxybook: installing i8402 key filter to capture hotkey input
[13210.058532] samsung_galaxybook: initializing fan speed
[13210.058568] samsung_galaxybook: Failed to read fan speed list
[13210.058575] samsung_galaxybook: Unable to get list of fan speeds
[13210.058578] samsung_galaxybook: initializing hwmon device
[13210.058663] samsung_galaxybook: enabling ACPI notifications
[13210.058666] samsung_galaxybook: [DEBUG] enabling ACPI feature
[13210.058669] samsung_galaxybook: [DEBUG]     43 58 86 00 00 bb aa 00 00 00 00 00 00 00 00 00
[13210.058671] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[13210.059809] samsung_galaxybook: [DEBUG] response was:
[13210.059812] samsung_galaxybook: [DEBUG]     43 58 86 00 aa dd cc 00 00 00 00 00 00 00 00 00
[13210.059815] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[13210.059817] samsung_galaxybook: [DEBUG] activate ACPI notifications
[13210.059819] samsung_galaxybook: [DEBUG]     43 58 86 00 00 80 02 00 00 00 00 00 00 00 00 00
[13210.059821] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[13210.061880] samsung_galaxybook: [DEBUG] response was:
[13210.061882] samsung_galaxybook: [DEBUG]     43 58 86 00 aa 02 00 00 00 00 00 00 00 00 00 00
[13210.061884] samsung_galaxybook: [DEBUG]     00 00 00 00 00
[13210.061887] samsung_galaxybook: initializing hotkey input device
[13210.061974] input: Samsung Galaxy Book extra buttons as /devices/platform/samsung-galaxybook/input/input39
[13210.062108] samsung_galaxybook: enabling WMI notifications
[13210.062125] samsung_galaxybook: installing WMI notify handler
[13210.062188] samsung_galaxybook: driver successfully loaded

And nothing in the sensors:

samsung_galaxybook-isa-0000
Adapter: ISA adapter
fan1:             N/A

i915-pci-0300
Adapter: PCI adapter
in0:         635.00 mV 
power1:           N/A  (max =  40.00 W)
energy1:       2.92 kJ

iwlwifi_1-virtual-0
Adapter: Virtual device
temp1:        +41.0°C  

nvme-pci-0400
Adapter: PCI adapter
Composite:    +30.9°C  (low  = -273.1°C, high = +82.8°C)
                       (crit = +84.8°C)
Sensor 1:     +30.9°C  (low  = -273.1°C, high = +65261.8°C)

ucsi_source_psy_USBC000:002-isa-0000
Adapter: ISA adapter
in0:           0.00 V  (min =  +0.00 V, max =  +0.00 V)
curr1:         0.00 A  (max =  +0.00 A)

ucsi_source_psy_USBC000:001-isa-0000
Adapter: ISA adapter
in0:           0.00 V  (min =  +0.00 V, max =  +0.00 V)
curr1:         0.00 A  (max =  +0.00 A)

coretemp-isa-0000
Adapter: ISA adapter
Package id 0:  +53.0°C  (high = +100.0°C, crit = +100.0°C)
Core 0:        +49.0°C  (high = +100.0°C, crit = +100.0°C)
Core 4:        +45.0°C  (high = +100.0°C, crit = +100.0°C)
Core 8:        +46.0°C  (high = +100.0°C, crit = +100.0°C)
Core 12:       +46.0°C  (high = +100.0°C, crit = +100.0°C)
Core 16:       +51.0°C  (high = +100.0°C, crit = +100.0°C)
Core 17:       +51.0°C  (high = +100.0°C, crit = +100.0°C)
Core 18:       +51.0°C  (high = +100.0°C, crit = +100.0°C)
Core 19:       +51.0°C  (high = +100.0°C, crit = +100.0°C)
Core 20:       +52.0°C  (high = +100.0°C, crit = +100.0°C)
Core 21:       +52.0°C  (high = +100.0°C, crit = +100.0°C)
Core 22:       +52.0°C  (high = +100.0°C, crit = +100.0°C)
Core 23:       +52.0°C  (high = +100.0°C, crit = +100.0°C)

BAT1-acpi-0
Adapter: ACPI interface
in0:          14.86 V  
curr1:         1.26 A  

If you want, can you check the _FST method for both of your fans and see if it works on your device or not?

Of course, I got:

marcus@laptop:~$ echo '\_SB.PC00.LPCB.H_EC.FAN1._FST' | sudo tee /proc/acpi/call && sudo cat /proc/acpi/call
\_SB.PC00.LPCB.H_EC.FAN1._FST
[0x0, 0x49, 0xce4]

marcus@laptop:~$ echo '\_SB.PC00.LPCB.H_EC.FAN2._FST' | sudo tee /proc/acpi/call && sudo cat /proc/acpi/call
\_SB.PC00.LPCB.H_EC.FAN2._FST
[0x0, 0x50, 0xce4]

I tested with 6.11.3 and it works quite well. Also, a nice bonus with 6.11.3 is that your speakers will start working (as long as your device is in the quirk table of patch_realtek.c) 😉 😎

Little question. Does your speakers 100% don't work without tweaks? Mine works well out of the box with Ubuntu 24.04 (kernel 6.8.0)

Regarding question on hotkey, well.. it was because in 6.10 they added this function that takes care of the cycle for you (platform_profile_cycle)... otherwise the logic is kind of complicated, and instead of building my own custom logic, I decided to use that new function to take care of this toggling

Sorry, but can you explain this, please? We couldn't just get the current performance profile and set to the next if the kernel version < 6.10? Isn't just like 3 or 4 if statements? I think this driver thing is a little lower level than I am used to (which is a shame, because I wanted to try to create the driver for my fingerprint scanner)

[joshuagrisham]

Hi thank you! Regarding the hotkey support, well, it was going to be a little more complicated than that, and I knew that the maintainers would want me to do what I did anyway (just use the method and remove anything else), so I did not think more on it. But for now I added some code to hopefully solve this for you ... it will be removed later when the driver is mainlined, just FYI :)

Please try it and let me know if you have any issues!

Regarding your logs, it looks promising, but I would like to see if it works now to set and get all of the different flags, or if you are still getting failures?

Regarding the fan speeds, good news, it looks like your methods are working... I can try to look into this more later :)

Regarding fingerprint driver, if your device using a MoC scanner from EGIS then I made a driver for that also :) https://gitlab.freedesktop.org/libfprint/libfprint/-/blob/master/libfprint/drivers/egismoc/egismoc.c

Please create an issue at libfprint for support for your device if it is the same kind of model but not working for you :sunglasses: It can be that there needs to be more development on the driver...for example I have been in correspondence with someone who wanted to implement the 1c7a:0588 but there is a Windows Hello-based "nonce" generated which sort of "signs" the IDs that are stored in the reader, and this particular device rejects the IDs if you do not follow this requirement, and we have not figured out how to make it work yet.... that we can take in libfprint, though :innocent:

[joshuagrisham]

Regarding your fan speed...

Of course, I got:

marcus@laptop:~$ echo '\_SB.PC00.LPCB.H_EC.FAN1._FST' | sudo tee /proc/acpi/call && sudo cat /proc/acpi/call \_SB.PC00.LPCB.H_EC.FAN1._FST
[0x0, 0x49, 0xce4]

marcus@laptop:~$ echo '\_SB.PC00.LPCB.H_EC.FAN2._FST' | sudo tee /proc/acpi/call && sudo cat /proc/acpi/call \_SB.PC00.LPCB.H_EC.FAN2._FST
[0x0, 0x50, 0xce4]

On your device, it seems that Samsung got the _FST method right but they did not implement any of the other methods in the ACPI 4.0 specification (https://uefi.org/specs/ACPI/6.5/11_Thermal_Management.html#fan-device)

In your examples, according to your device's _FST method, both of your fans were operating at 3300 RPM at the time (0xce4 = 3300)

For everything to show up "automatically" from the ACPI Fan Device, all 4 methods have to be present (see drivers/acpi/fan_core.c#L206-L212)

I am not sure how it is "typically" done in the kernel when the _FST method is working correctly but not supported out-of-the-box by ACPI Fan support... my assumption is that this driver can just add them to its own hwmon support but I will need to redo the logic a bit to maybe do something like this:

1. get all fans for the device
2. for each one, see if they are somehow supported out-of-the-box already (e.g. all 4 methods are present or similar)
3. if not, test their _FST method
4. if _FST method is good, then add fan_speed_rpm attribute and add hwmon fan channel for it, plus ensure that the "get_speed" method will execute _FST and fetch the speed from the method
5. if _FST method is not good, then check for existence of FANS and FANT and then set those up instead (similar to point 4 above)

I will create a separate issue just to track this specifically

[joshuagrisham]

Regarding the rest @seaasses I made some tweaks today where I realized there were some very small risk for some null pointer references depending on parameters and potential failures during init etc so hopefully that should be in a better place now as well. Would you mind to test how it works with the latest on this branch and see if writing / reading all of the different attributes is working or not for your device? If it looks good then I will merge this branch in and then can keep looking into the fan speed issue a bit later since it will be a bit more work...

[joshuagrisham]

@seaasses I created a PR and merged in the latest of that old branch into main now. When I did this, the issue also got closed... but if you still have issues specifically with the attributes (e.g. start_on_lid_open etc) then please write here and I will take a look again.