Failure to compile on Kernel 6.12.0-0.rc3

[achapleau]

Running Fedora Rawhide with kernel 6.12.0-0.rc3.20241015giteca631b8fe80.32.fc42.x86_64 when I run command make -C /lib/modules/uname -r/build M=$PWD I get the following output: make: Entering directory '/usr/src/kernels/6.12.0-0.rc3.20241015giteca631b8fe80.32.fc42.x86_64' CC [M] /home/andrew/samsung-galaxybook-extras/samsung-galaxybook.o /home/andrew/samsung-galaxybook-extras/samsung-galaxybook.c: In function ‘galaxybook_wmi_notify’: /home/andrew/samsung-galaxybook-extras/samsung-galaxybook.c:1578:18: error: implicit declaration of function ‘wmi_get_event_data’; did you mean ‘acpi_get_event_status’? [-Wimplicit-function-declaration] 1578	status = wmi_get_event_data(value, &response);	^~~~~~	acpi_get_event_status /home/andrew/samsung-galaxybook-extras/samsung-galaxybook.c: In function ‘galaxybook_wmi_init’: /home/andrew/samsung-galaxybook-extras/samsung-galaxybook.c:1599:70: error: passing argument 2 of ‘wmi_install_notify_handler’ from incompatible pointer type [-Wincompatible-pointer-types] 1599	return wmi_install_notify_handler(GALAXYBOOK_WMI_EVENT_GUID, galaxybook_wmi_notify, NULL);	^~~~~
void ()(u32, void ) {aka void ()(unsigned int, void )}

In file included from /home/andrew/samsung-galaxybook-extras/samsung-galaxybook.c:18: ./include/linux/acpi.h:404:60: note: expected ‘wmi_notify_handler’ {aka ‘void ()(union acpi_object , void )’} but argument is of type ‘void ()(u32, void )’ {aka ‘void ()(unsigned int, void )’} 404 | wmi_notify_handler handler, void data); | ~~~~~^~~~~ make[2]: [scripts/Makefile.build:229: /home/andrew/samsung-galaxybook-extras/samsung-galaxybook.o] Error 1 make[1]: [/usr/src/kernels/6.12.0-0.rc3.20241015giteca631b8fe80.32.fc42.x86_64/Makefile:1982: /home/andrew/samsung-galaxybook-extras] Error 2 make: *** [Makefile:236: __sub-make] Error 2 make: Leaving directory '/usr/src/kernels/6.12.0-0.rc3.20241015giteca631b8fe80.32.fc42.x86_64'

Downgrading to stable kernel 6.11.4 solved the issue.

[achapleau]

Just for fun, tried it on the debug disable kernel 6.12.rc2 out of the RawhideKernelNodebug kernel repo and same error:

[joshuagrisham]

Hi @achapleau just curious if you have tried this now with any later version of 6.12 ? I have found that it is a bit tough to know which versions of latest mainline/"next" will actually build or have a lot of regressions so it has been always a trial-and-error process for me personally to try and build latest mainline.

Also specifically for this WMI stuff I have removed all of the WMI stuff in the latest proposed version of this driver; could you maybe give it a try per the info in https://github.com/joshuagrisham/samsung-galaxybook-extras/pull/40 and see if this helps?