Add support to `SAM0430` ACPI device

joshuagrisham / samsung-galaxybook-extras

Samsung Galaxybook Linux platform driver and accompanying utilities.

116 stars 15 forks source link

Add support to `SAM0430` ACPI device #38

Closed jusqua closed 3 weeks ago

jusqua commented 3 weeks ago

Add SAM0430 ACPI device SCAI to supported devices list.

jusqua commented 3 weeks ago

Hi, @joshuagrisham. My device is a Samsung Galaxy Book4 (NP750XGJ-KG2BR) with the SAM0430 ACPI device ID.

This PR just add the SAM0430 ACPI device SCAI to ACPI device IDs list.

jusqua commented 3 weeks ago

The only features that is not working fine are:

USB charging (I don't know if my device support this feature)
Not recognizing fan speeds
~~Power profiles not changes with TLP, thus some logs are displayed when driver is loaded~~. Need to be manually specified in /etc/tlp.conf, my bad.

Also here some tests that I have done and logs that I have extracted based on your comment in issue #31 that might help debug the device.

The zipped file attached in the comment have logs and the SamsungSystemSupportEngine binary with .inf file. important-files.zip

joshuagrisham commented 3 weeks ago

Hi @jusqua thank you this looks good, so I will just merge it directly in! Question: is USB charging and fan speed the only thing not working, and everything else works? e.g. keyboard backlight etc ? Just wondering if we need to consider any quirk for SAM0430 that is a lot different than the prior models

jusqua commented 3 weeks ago

Hi @joshuagrisham. Yes, USB charging and fan speed only. My device comes without a keyboard backlight, so there is no reason to consider it.

I have been using the kernel module since I opened the PR, and I have found no problems except those.

Thanks for the merging.