search

joshualeejunyi / pe

0 stars 0 forks source link

Having a meal in the same format as a water log prevents the user from deleting the water log #7

Open joshualeejunyi opened 5 months ago

joshualeejunyi commented 5 months ago

Description: When a user adds a meal log to the same format as a water log (e.g. meal name: 100 ml), and has a 100ml water log, the user is unable to delete the water log unless they first delete the meal log.

Steps to Reproduce:

  1. Add a meal log in the format of a water log: log m/100 ml c/100 s/1
  2. Add a water log: log w/100
  3. Attempt to delete the water log: delete 100 ml

Actual Result: The application Description: When a user changes the integer values in data.txt to negative values, the application does not check it when importing the data and thus negative values are shown.

Steps to Reproduce:

  1. Open data.txt in the data folder
  2. Change any integer value to a negative number (e.g. -100)
  3. Run the jar file

Actual Result: The application first deletes the meal log before the water log.

Screenshot:

image.png

soc-pe-bot commented 5 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

FLaw in delete

image.png

If meal and exercise has the same name, it will delete in meal, eventhough user may want to delete exercise

[original: nus-cs2113-AY2324S2/pe-interim#1580] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Realistically, an exercise and food would not have the same name. Thus, in any other situation, the application would identify between a meal and exercise correctly, especially since rojak was a part of our FoodData.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]