Open joshuan98 opened 1 year ago
Contrary to popular belief, YAMOM makes no API calls to NUSMods - it is a completely self-contained application.
Team chose [response.Rejected
]
Reason for disagreement: Yes it is true that YAMOM has no API calls to NUSMods. However, two of YAMOM's features are import and export. This link is most certainly from NUSMods. As such, it may be hard to test these two functions without using NUSMods. If the internet is down, it means that those two features cannot be tested.
Moreover, during my testing I had to search for modules that might cause edge cases. This was hard-to-test without using NUSMods filters to find modules that may potentially cause errors.
Yamom requires the use of nusmods, which may be difficult to navigate, to test its core features