joshuan98 / pe

0 stars 0 forks source link

Does not fulfill constraints #17

Open joshuan98 opened 1 year ago

joshuan98 commented 1 year ago

Yamom does not fulfill the constraint of a human-editable-file since its text file is read-only and hidden

image.png

nus-se-script commented 1 year ago

Team's Response

Data is stored as plaintext (.txt) - it is neither in a binary format nor uses any unusual encoding nor is it encrypted.

Precisely because it is only for advanced users to manipulate, it is set to be read-only and hidden, because an advanced user would be able to view hidden files and change read-only files.

.bashrc on unix systems is also a hidden text file that is editable by humans.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: "Data is stored as plaintext (.txt) - it is neither in a binary format nor uses any unusual encoding nor is it encrypted." - This is a fair point but I did not mention any issues with the file type. The bug is regarding the txt file being read-only and hidden.

".bashrc on unix systems is also a hidden text file that is editable by humans." - I believe that the default .bashrc is not read-only.

The fact remains that if the file is read-only then it is not editable, which directly contradicts the constraint.

On one hand, the severity may be high because it directly contradicts the constraints. On another hand, the severity may be medium because it only hinders advanced users.