search

joshuapinter / react-native-unified-contacts

Your best friend when working with the latest and greatest Contacts Framework in iOS 9+ in React Native.
MIT License
158 stars 56 forks source link

Support react-native v0.40+ #17

Closed joonhocho closed 7 years ago

joonhocho commented 7 years ago

Support react-native v0.40+

justinobney commented 7 years ago

https://medium.com/@thisismissem/how-to-upgrade-react-native-modules-in-a-backwards-compatible-manner-a5b5c48d590c#.p714l4p8r

joshuapinter commented 7 years ago

Thanks @joonhocho for the PR and @justinobney for the link to the backwards compatibility hack.

@joonhocho, can you update this PR with the backwards compatible version, like this: 

#if __has_include("RCTBridgeModule.h")
#import "RCTBridgeModule.h"
#else
#import <React/RCTBridgeModule.h>
#endif

And then, if possible, do a quick test on both RN < 0.40 and RN >= 0.40?

Thanks!

joonhocho commented 7 years ago

@justinobney @joshuapinter I will close this one and remake one.