search

joshuapinter / react-native-unified-contacts

Your best friend when working with the latest and greatest Contacts Framework in iOS 9+ in React Native.
MIT License
158 stars 56 forks source link

Adds support for field filtering. #32

Closed jyliang closed 1 year ago

joshuapinter commented 6 years ago

Wow, this looks like a great update. Thanks!

Since it's such a big change, I'd like to get some tests in there before merging. Any chance you can write some basics tests for those new methods?

jyliang commented 6 years ago

cool, i'll try to get some in after the holidays. happy holidays btw!

joshuapinter commented 6 years ago

@jyliang Awesome, and likewise!!

paintedbicycle commented 6 years ago

Hey @jyliang this feature is exciting. Are you able to bring in some of the more recent changes from the master branch since your PR and then thoroughly test it? Would love to see this merge.

Also, we've updated the Android branch, so this feature would be a good one to also have over there as we're starting to get to a point where we can bring Android support to master.

bradennapier commented 5 years ago

Was just about to ask about this functionality. Nice work @jyliang although its almost a year old now heh