joshuapinter / react-native-unified-contacts

Your best friend when working with the latest and greatest Contacts Framework in iOS 9+ in React Native.
MIT License
158 stars 56 forks source link

Swift Migration #35

Closed elliotfleming closed 6 years ago

elliotfleming commented 6 years ago

Please consider migrating this project to Swift 4 or at least 3.2...

I realize you aren't maintaining this project anymore but this is the ONLY React Native library that supports all the Contacts features and yet it's the only one that will not work with Xcode 9.2.

It would take a short time and have a big impact. Thank you!

joshuapinter commented 6 years ago

Hey @elliotfleming. Thanks for the suggestion!

I am maintaining it but just short on time these days. It's still a priority for me as we use it in http://ntwrkapp.com/ in as well.

I'll take a look at this and let you know.

joshuapinter commented 6 years ago

Hi @elliotfleming. I opened it up in XCode 9.2 and got everything working with Swift 4.

I created an ExampleApp with the latest version of React Native (0.52.2) as well.

This was done in #36.

I published a new version to npm, 1.6.1.

Can you try that out and let me know if everything is working for you?

Make sure to test the ExampleApp, as per the README Instructions, if you run into trouble.

elliotfleming commented 6 years ago

Many many thanks! Working now!

joshuapinter commented 6 years ago

@elliotfleming Awesome! Thanks for following up!