search

joshuapinter / react-native-unified-contacts

Your best friend when working with the latest and greatest Contacts Framework in iOS 9+ in React Native.
MIT License
158 stars 56 forks source link

Module RNUnifiedContacts requires main queue setup #41

Closed piotrgorecki closed 6 years ago

piotrgorecki commented 6 years ago

Hi

I have got the following yellow box warning:

Module RNUnifiedContacts requires main queue setup since it overrides constantsToExport but doesn't implement requiresMainQueueSetup. In a future release React Native will default to initializing all native modules on a background thread unless explicitly opted-out of.

RN: 54.2 react-native-unified-contacts: 1.6.2

paintedbicycle commented 6 years ago

Hi @piotrgorecki can you try PR https://github.com/joshuapinter/react-native-unified-contacts/pull/45 and let me know if it fixes it?

Thanks

paintedbicycle commented 6 years ago

@joshuapinter I'd like to hear from @piotrgorecki on this one as I saw this error but it was elusive. I want to make sure I actually solved it. @piotrgorecki can you confirm? If you need me to dig deeper, let me know and I can try to recreate. I'm not super solid with Swift just yet and I have some doubts about the +'s in my PR. Over to you @piotrgorecki

paintedbicycle commented 6 years ago

Ok, I have re-confirmed this fix. We're good.

joshuapinter commented 6 years ago

@paintedbicycle Great job!

piotrgorecki commented 6 years ago

Hi @paintedbicycle ! I checked your fix and it works great. Thanks and I'm sorry for the late answer.

paintedbicycle commented 6 years ago

@piotrgorecki Good to hear!

bradennapier commented 5 years ago

Any plans to implement this in the actual repo? I am getting this warning - just installed for my first time.

image

paintedbicycle commented 5 years ago

It was fixed (as shown above), what version of the repo are you using?

You may have to use the bleeding edge:

package.json:

   "react-native-unified-contacts": "https://github.com/joshuapinter/react-native-unified-contacts.git",