search

joshuapinter / react-native-unified-contacts

Your best friend when working with the latest and greatest Contacts Framework in iOS 9+ in React Native.
MIT License
158 stars 56 forks source link

Create contact #5

Closed homanp closed 8 years ago

joshuapinter commented 8 years ago

Wow dude! This is a huge PR, nice work! I'll take a look today and see if I can merge it in.

homanp commented 8 years ago

@joshuapinter agree on all points. Will fix and commit.

joshuapinter commented 8 years ago

@homanp Awesome. I added a few more comments. Looking forward to the changes! :)

homanp commented 8 years ago

@joshuapinter I've refactored the code as per your comments. Also took the time to add some more labels to phone numbers and emails.

joshuapinter commented 8 years ago

@homanp Great work man. It's looking really good. I left some comments on the updates.

homanp commented 8 years ago

@joshuapinter yes, already fixed those. Need to investigate custom labels.

homanp commented 8 years ago

@joshuapinter strange thing is that there seems to be no documentation regarding custom labels. Perhaps a separate feature?

joshuapinter commented 8 years ago

@homanp Agreed. This is great as it is. If somebody else wants it they can create a new PR. Lol. I'll take a look at this locally and pull it in.

Great work with this.

homanp commented 8 years ago

@joshuapinter sounds good. I'm using this branch for my app and seems to be working fine. My sim was acting up so I had to implement it to a RN app to test.

joshuapinter commented 8 years ago

All merged in. Great job!

homanp commented 8 years ago

@joshuapinter cool, will create a PR for updateContact as well. Probably in 2 tomorrow or the day after that.

joshuapinter commented 8 years ago

👍