search

joshuapinter / react-native-unified-contacts

Your best friend when working with the latest and greatest Contacts Framework in iOS 9+ in React Native.
MIT License
158 stars 56 forks source link

Releasing Android #75

Closed chrisyeoward closed 4 years ago

chrisyeoward commented 6 years ago

Hi,

Unsure if this has been covered elsewhere, but there's no Android source in the latest NPM release.

Would you be able to push out a new release, or is Android still waiting on specific fixes?

Thanks,

paintedbicycle commented 6 years ago

Hey @chrisyeoward - the Android code isn't tagged to a specific version, but if you use the code in master, you'll get the Android functionality just fine. Keep in mind the compatibility table shown in the Readme - not all methods are available in Android.

There are a few ways to call master from npm but my package.json has this: "react-native-unified-contacts": "https://github.com/joshuapinter/react-native-unified-contacts.git"

Paul

joshuapinter commented 6 years ago

Thanks for responding, @paintedbicycle!

In newer versions of npm, you can also use a shortened version in your package.json file that looks like this: 

"react-native-unified-contacts": "joshuapinter/react-native-unified-contacts"
jimmythompson commented 6 years ago

Cheers for the quick reply. 😄

For context: I work with @chrisyeoward.

While we can definitely use Github for the time being, it'll probably be annoying - for us and yourselves - if we started depending on the master branch of your repo.

Are you planning on publishing new versions of this library to NPM in future? Is there anything we can help with?

paintedbicycle commented 6 years ago

Hey @jimmythompson - yes that makes sense. I'll reopen this.

In my mind the show stoppers holding this release up are #74 and #52 because in those two cases Android and iOS are not outputting the same thing. We can't release with that being the case.

Other than that, as long as people are comfortable with the support table in the readme (not all methods are available in Android yet), I don't see why a tagged release wouldn't be possible. Obviously that's up to @joshuapinter for final say, but that would be my vote.

We can then work on the other methods and issues after that.

Paul

joshuapinter commented 6 years ago

I agree. I think once we fix #74 and #52 we can release a new minor release to npm since there are no breaking changes.

We'll leave the 2.0.0 release for full Android support and Promises, which will introduce breaking changes.

joshuapinter commented 6 years ago

Just pushed a fix for #74. Just one more to go and we can get a new npm release out.

ibrahimab commented 6 years ago

Any way you need help with #52 ? Something you are stuck on? Would love to upgrade to a android supported version.

joshuapinter commented 6 years ago

@ibrahimab That would be great. If you read Issue #52, you'll see that we're looking for a way to interpret single line addresses. If you can give @paintedbicycle a hand with that, that would help a lot.

paintedbicycle commented 4 years ago

There's now an npm pre-release that you can use to try out the Android version.

https://www.npmjs.com/package/react-native-unified-contacts/v/2.0.0-pre.1