search

joshuapinter / react-native-unified-contacts

Your best friend when working with the latest and greatest Contacts Framework in iOS 9+ in React Native.
MIT License
158 stars 56 forks source link

No android folder when installing 1.6.2? #90

Closed DaRizat closed 5 years ago

DaRizat commented 5 years ago

When installing 1.6.2 from npm or yarn, the android folder is not present in the package folder, which makes linking impossible.

Workaround for now is cloning repo and copying android folder into the node_modules folder or cloning and linking the repo.

brascene commented 4 years ago

Why is this issue closed, it's still present like this, in my project that android folder is also missing..

paintedbicycle commented 4 years ago

@joshuapinter It might make sense to tag the current bleeding edge as an alpha release so people can at least try out the Android version using npm if they wanted to? I don't think many people know how to request the bleeding edge commits from a Git repo from their package.json and it's not that convenient to do so anyway

joshuapinter commented 4 years ago

Probably a good idea. You able to do that with your permissions?

paintedbicycle commented 4 years ago

I'll find out!

paintedbicycle commented 4 years ago

Ok I've pushed a tagged alpha release to Github (https://github.com/joshuapinter/react-native-unified-contacts/releases/tag/v2.0.0-alpha-1).

If I understand correctly, as the npm account owner you'll need to publish this tag as an alpha or beta release over there:

https://medium.com/@kevinkreuzer/publishing-a-beta-or-alpha-version-to-npm-46035b630dd7

joshuapinter commented 4 years ago

Done. Published to npm as 2.0.0-pre.1:

https://www.npmjs.com/package/react-native-unified-contacts/v/2.0.0-pre.1

paintedbicycle commented 4 years ago

Beauty.

@DaRizat @brascene - you're good to go