joshuaprince / SilkSigns

⛏️📜🪧 A Minecraft Paper plugin that allows picking up written signs with the Silk Touch enchantment.
GNU Affero General Public License v3.0
0 stars 0 forks source link

Hanging signs cause ClassCastException and do not drop with text #1

Closed logitechno closed 3 weeks ago

logitechno commented 1 month ago

When splitting a hanging sign, this error is displayed. The text is not saved Core: purpur Version: 1.21 https://mclo.gs/L3C2iHJ

joshuaprince commented 1 month ago

Confirmed on latest builds of Spigot, Paper, and Purpur.

This is caused by a bug in Spigot which was added with the item meta changes on 2024-07-06. I filed SPIGOT-7846 since it needs to be fixed there before the error here can be fixed. I don't see any easy workaround for SilkSigns until then. Until it's fixed in Spigot, Paper versions 89 and below (Purpur versions 2267 and below) should be unaffected.

joshuaprince commented 1 month ago

The underlying bug is now fixed in the latest Spigot builds, but since the plugin is for Paper+ only, the fix has to propagate downstream. https://github.com/PaperMC/Paper/issues/11160

joshuaprince commented 3 weeks ago

Fixed in all 1.21.1 server builds, as well as:

Upgrade your server if you're seeing the error with hanging signs.