joshuaskelly / quake-cli-tools

Command line tools for creating Quake content.
MIT License
75 stars 10 forks source link

Floor slicing and other enhancements #27

Closed alexkiri closed 10 months ago

alexkiri commented 10 months ago

This PR:

ad_start_x Extra screenshot - Start map from Arcane Dimensions, viewed from the x axis

joshuaskelly commented 10 months ago

Whoa! These seem like great enhancements! Give me some time to review the changes?

alexkiri commented 10 months ago

Sure thing, take your time. Python is not my main language, but I spent some time to (hopefully) code it right. I like this tool so much, it really brings a certain beauty in every map. Excellent work. I've had fun extending it

alexkiri commented 10 months ago

I just pushed a new commit. Sorry if this complicates the review. I added the functionality to control the slicing-axis. This is an essential part for this feature, as you can see in the next screenshot. But I had to rename arguments and variables accordingly (mainly floor -> slice)

image start map of qbj2 - Ears to the Heavens by Makkon, projected and sliced along the y axis, with half of the slices hidden

joshuaskelly commented 10 months ago

No sweat. I'll wait until you are done making changes before I start my review.

joshuaskelly commented 10 months ago

Also can you provide usage examples?

E.g. foo -d ./out -v

alexkiri commented 10 months ago

Closed because https://github.com/joshuaskelly/quake-cli-tools/pull/29