search

joshuaskelly / quake-cli-tools

Command line tools for creating Quake content.
MIT License
69 stars 10 forks source link

Chore request: Rename the existing image/sprite tools #33

Open jonathanlinat opened 7 months ago

jonathanlinat commented 7 months ago

Hi Joshua! 👋

I've been looking into our tool names and thought of a more accurate naming scheme:

Both tools currently work exclusively with GIF files. Adopting these names would reflect their actual functionality and help us establish a clearer naming convention across our toolkit. Sounds like a win-win, right? 🚀

joshuaskelly commented 7 months ago

Incorrect. They support all formats supported by Pillow. https://pillow.readthedocs.io/en/stable/handbook/image-file-formats.html

In theory you could create an spr from a .PSD, or convert an spr into a .PDF!

jonathanlinat commented 7 months ago

Understood. So, those scripts must be adjusted based on your explanation. They are only referencing the GIF format in their codebase.

joshuaskelly commented 7 months ago

The code is actually fine. I created PNG and PDF versions of s_bubble.spr. What bit of code are you referencing?

jonathanlinat commented 7 months ago

Yep, you are absolutely right. The code is OK, but the instructions are not. There are only references to the GIF format.

image

As you can see, I do believe these need to be adjusted to ensure the developers and mappers understand that this script is working with all the formats provided by Pillow, as you mentioned.

Does that make sense?