search

joshuaskelly / twitch-observer

Turn Twitch chatter into Python events
MIT License
26 stars 6 forks source link

Creating a default TWITCHCHATCOMMAND Type #29

Closed joshuaskelly closed 7 years ago

joshuaskelly commented 7 years ago

Overview

The change here is to improve the event types for the messages that we don't handle. Right now they just show up with the command as the type. This isn't very useful.

I propose to have a basic TWITCHCHATCOMMAND that represents a server message that we receive, but don't do any special handling around.

Additionally I'm adding a _params attribute to the event so if a consumer of the event is interested in that data, they have it.

Example Log

event.type: event._command

TWITCHCHATCOMMAND: 001
TWITCHCHATCOMMAND: 002
TWITCHCHATCOMMAND: 003
TWITCHCHATCOMMAND: 004
TWITCHCHATCOMMAND: 375
TWITCHCHATCOMMAND: 372
TWITCHCHATCOMMAND: 376
TWITCHCHATCOMMAND: CAP
TWITCHCHATCOMMAND: CAP
PythooonUser commented 7 years ago

Good idea!

joshuaskelly commented 7 years ago

Are you okay with me merging it in?