joshuaskelly / twitch-observer

Turn Twitch chatter into Python events
MIT License
26 stars 6 forks source link

The Chat Moderation Update #48

Closed PythooonUser closed 7 years ago

PythooonUser commented 7 years ago

Summary

I felt like adding these methods since we have some moderation commands built in but not all of them.

Currently available:

Adding:

Questions

QUESTION: There are also commands for playing commercials, hosting and unhosting other channels. I do not feel these to be directly related to the chat. Do we want to add them anyways or not?

QUESTION: Are there any unit tests I can add for those new methods? They are just wrappers for the TwitchObserver.send_message method so I'm not sure how to deal with it. Having a test for send_message is sufficient?

PythooonUser commented 7 years ago

What about those questions @JoshuaSkelly?

joshuaskelly commented 7 years ago

I think for the time we can leave out commercials and hosting.

I don't think we need any tests for this. As you said, the underlying method is tested. As long as you've manually tested the new commands, I'm happy.

PythooonUser commented 7 years ago

I did. Hopefully I did not screw it up :D