search

joshuaskelly / twitch-observer

Turn Twitch chatter into Python events
MIT License
26 stars 6 forks source link

Potential typo ("sever" -> "server") #63

Closed senpos closed 6 years ago

senpos commented 6 years ago

All of these are typos, I guess.

senpos commented 6 years ago

@PythooonUser Yes, sure!

PythooonUser commented 6 years ago

Yes, those are typos. Do you want to create a PR for that?

senpos commented 6 years ago

@PythooonUser I'd also like to ask about using self.nickname atribute here, as well as in TwitchChatEvent docstrings, is this a mistake? I don't see it in __init__. Actually, I don't see it anywhere in the project.

Should I fix it in the same PR and name it like "Fix typos & unused nickname attr"? Give me some recommendations please.

PythooonUser commented 6 years ago

No, this is one of the most important variables! :D Look at _process_server_messages. Here the nickname is set. This variable is send for JOIN, PART and MSG events to identify the user that triggered it. We had a discussion about the naming once. We stayed with the Twitch way of naming things.

senpos commented 6 years ago

@PythooonUser Oops! I searched for self.nickname rather than nickname! Sorry.

PythooonUser commented 6 years ago

No problem. So I think fixing the typos in your PR is sufficient for now ;)