Fix typos in "server" word

joshuaskelly / twitch-observer

Turn Twitch chatter into Python events

MIT License

26 stars 6 forks source link

Fix typos in "server" word #64

Closed senpos closed 6 years ago

senpos commented 6 years ago

Closes #63

joshuaskelly commented 6 years ago

👍 Looks good to me!

PythooonUser commented 6 years ago

Looks good!

Two things before merging though:

Please update version to 0.9.1 in the __init__.py file
Add a new section in the CHANGELOG.md with a Fixed section

Thanks!

senpos commented 6 years ago

@PythooonUser Sure, I can do that. Just curious: is it how you deal with versioning? Like, every PR is a new version? I haven't worked with such schema before, almost all project I've seen are doing it a bit differently, like they accumulate PRs and then push a release with all of them bundled together with a big changelog.

joshuaskelly commented 6 years ago

We use Semantic Versioning https://semver.org/

Technically we should only change the version when we publish. Since @PythooonUser already bumped the version number, you don't have to.

joshuaskelly commented 6 years ago

@Senpos I will wait for you to get your changes in and I'll publish the new version to PyPi.

senpos commented 6 years ago

I am not sure, was it a proper way to make changes to code, that was already edited, but I hope so, LOL