Simplify Naming Conventions

[joshuaskelly]

Summary

Many of the classes and attributes have redundant info and should be simplified. e.g.

TwitchChatObserver -> Observer

Proposed Names

Classes

Current	Proposed
BadTwitchChatEvent	BadEvent
TwitchChatEvent	Event
TwitchChatObserver	Observer
TwitchChatColor	Color

Chat Event Types

Current	Proposed
TWITCHCHATJOIN	JOIN
TWITCHCHATLEAVE	LEAVE
TWITCHCHATMESSAGE	MESSAGE
TWITCHCHATMODE	MODE
TWITCHCHATCLEARCHAT	CLEARCHAT
TWITCHCHATHOSTTARGET	HOSTTARGET
TWITCHCHATNOTICE	NOTICE
TWITCHCHATRECONNECT	RECONNECT
TWITCHCHATROOMSTATE	ROOMSTATE
TWITCHCHATUSERNOTICE	USERNOTICE
TWITCHCHATUSERSTATE	USERSTATE
TWITCHCHATWHISPER	WHISPER
TWITCHCHATCOMMAND	COMMAND

[joshuaskelly]

If I missed any names or if there is a better naming scheme, let me know.

[PythooonUser]

Question: What about the strings of the ChatEventTypes? Do they stay the same?

Question: Am I right that the aliases defined in the __init__.py file aren't required any more?

[joshuaskelly]

What about the strings of the ChatEventTypes? Do they stay the same?

I think we should change those? Since we are already making big breaking changes.

Am I right that the aliases defined in the init.py file aren't required any more?

I'd say yes, we can remove those.

[PythooonUser]

I think we should change those?

What about naming conflicts with e.g. tdl, pygame or custom event types?

[joshuaskelly]

Good point. Maybe we can wait before changing those? I'm not quite sure yet how I feel about that change.

[PythooonUser]

I'm not quite sure yet how I feel about that change.

About the whole change? Please, speak up if you have any concerns!

[PythooonUser]

Anyways, I'm willing to work on this issue.

[joshuaskelly]

Go for it! 😄