search

joshuataylor / ueberauth_esi

Ueberauth authentication for ESI, for EVE Online
MIT License
0 stars 1 forks source link

callback_url vs redirect_uri #3

Open blackmadness opened 4 years ago

blackmadness commented 4 years ago

By default the package is configured to use:

    /auth/:provider
    /auth/:provider/callback

But, apparently, we can use redirect_uri in the config to ask for a different callback. It is anyway little smoky, since the docs state (https://github.com/joshuataylor/ueberauth_esi/blob/master/lib/ueberauth/strategy/esi/oauth.ex#L47) that this is working only outside of the normal callback phase of the strategy.

Also, if we provide the redirect_uri parameter, it's actually ignored, and the standard one is being used. It happens because of the callback_url(conn) function here: https://github.com/joshuataylor/ueberauth_esi/blob/master/lib/ueberauth/strategy/esi.ex#L95. Note that this behaviour is driven by the send_redirect_uri flag, which is not documented (maybe it is in UeberAuth ?).

Is this working as intended ?