search

joshuatz / linkedin-to-jsonresume

Browser extension to turn a LinkedIn profile page into a JSON Resume export.
https://joshuatz.com/projects/web-stuff/linkedin-profile-to-json-resume-exporter/
MIT License
257 stars 61 forks source link

Does not download all volunteer positions #55

Closed fkrauthan closed 3 years ago

fkrauthan commented 3 years ago

It seems like for some reason it does not download all volunteer positions (only top 3 are included in the json).

joshuatz commented 3 years ago

@fkrauthan Thanks for reporting. I can confirm this issue exists - for certain items within a profile, LinkedIn will only load the first three entries, and require that subsequent entries be loaded lazily, with pagination (e.g., if you have 5 volunteer entries, you get the first 3 on the initial page load, and the final 2 have to be separately loaded).

I've added code to check if volunteer experiences are truncated, and if so, perform the necessary action to load and parse the remaining entries. This fix has been rolled into the new v3.0.0 release.

Thanks for reporting, and also kudos on having that many volunteer experiences! 😄

fkrauthan commented 3 years ago

haha thanks. Yeah I am currently redoing my website and plan to regenerate most of my about me page based on linkedin data so I've noticed that some stuff was missing :D I did actually build a quick local fix for that as well. But I was not able to figure out how to retrieve them in the proper order (the only endpoint I could find returns them in a random order).

joshuatz commented 3 years ago

returns them in a random order

😬 Whoops, I'm like 99% certain I need to reopen this issue now lol. I totally forgot about ordering and although v3.0.0 now brings in all volunteer entries, it does a direct lookup by type, which does not preserve order.

fkrauthan commented 3 years ago

I also tried to check what LinkedIn itself is issuing to load the rest of volunteer entries but couldn't see any API call. But to be honest a lot of the way linkedin does looks rather strange.

joshuatz commented 3 years ago

@fkrauthan OK, ordering should fixed now too (in latest v3.1.0 release). The fix for this should actually fix ordering in a few other places, so thanks for reminding me about it!

And about the way LinkedIn internal APIs / loaders work... yeah, they are indeed strange.

fkrauthan commented 3 years ago

Perfect I will give this and the other ticket a try probably tomorrow :)