Certain date ranges may start after they end

mullwaden commented 1 year ago

A profile might, on a work experience for example, have a date range that is "2007 - oct 2007". The this fix will interpret that as "2007-12-31 - 2007-10-31".

Start ends up bigger than end. I would suggest the fix is the following:

for end dates continue as is done currently ("year-12-31")
for start dates chose instead "year-01-01"

Maybe this will break a lot of things for people... Otherwise I am happy to make a PR.

joshuatz commented 1 year ago

@mullwaden I can certainly see your point of view, and appreciate that you have proposed a fix. I think this change makes sense - I'm including a table of how I would expect parsing to change with this, in case you, or anyone else wants to work on a PR. I could eventually get to this myself, but have less time right now, so it might be a while.

LinkedIn Date	Start vs End	Currently Parsed	New Parser
2007	Start	2007-12-31	2007-01-01
2007	End	2007-12-31	2007-12-31
Dec 2007	Start	2007-12-31	2007-12-01
Dec 2007	End	2007-12-31	2007-12-31
Dec 4th, 2007	Start	2007-12-04	2007-12-04
Dec 4th, 2007	End	2007-12-04	2007-12-04

Side note: I wouldn't mind refactoring a lot of the date-related code; it could use some improvement in general.

mullwaden commented 1 year ago

https://github.com/joshuatz/linkedin-to-jsonresume/pull/80

something like this maybe?

joshuatz / linkedin-to-jsonresume

Certain date ranges may start after they end #78