search

joshuaulrich / TTR

Technical analysis and other functions to construct technical trading rules with R
GNU General Public License v2.0
325 stars 102 forks source link

108 fix #111

Closed ethanbsmith closed 3 years ago

ethanbsmith commented 3 years ago

runXXX functions were forcing the first value to always be NA when n = 1 and cumulative = T when n =1, the first value should be the same, regardless of whether cumulative = T or cumulative = F This was not an issue for n >1 and cumulative = T

closes #108

joshuaulrich commented 3 years ago

Hi Ethan, thanks for the PR! Can you give me permission to push to this branch so I can make a couple minor changes?

ethanbsmith commented 3 years ago

hmm, looks checked image

joshuaulrich commented 3 years ago

Figured it out. It was my fault. Thanks for checking.