search

joshuaulrich / TTR

Technical analysis and other functions to construct technical trading rules with R
GNU General Public License v2.0
330 stars 103 forks source link

Prepare for gcc 10 defaults #87

Closed joshuaulrich closed 4 years ago

joshuaulrich commented 4 years ago

From Prof Ripley:

[TTR fails] to install with gcc trunk which is due to be released as gcc 10.0.x early in 2020. It defaults to -fno-common, which stricter on some multiply-defined symbols -- see §1.6.4.1 of 'Writing R Extensions' in current R-devel.

See https://www.stats.ox.ac.uk/pub/bdr/gcc10/ for the logs, which will be linked from the CRAN results page under 'Additional issues'.

We expect the issues to also be seen when compiling with earlier versions of gcc using the (non-default) flag -fno-common: this has been confirmed for gcc 9 on Linux, and also for clang on macOS.

Add -fno-common to PKG_CFLAGS in ~/.R/Makevars to reproduce.