joshuaulrich / quantmod

Quantitative Financial Modelling Framework
http://www.quantmod.com/
GNU General Public License v3.0
809 stars 223 forks source link

centralize getQuote strsplit processing #284

Closed ethanbsmith closed 4 years ago

ethanbsmith commented 4 years ago

Description

getQuote and getSymbols accept ";" delimited symbols as input. Not all dispatched getQuote implementations handle this. better to consolidate this into the master getQuote function before dispatching to to the sources.

Minimal, reproducible example

getQuote(c("SPY;WYSIWIG"), src="tiingo")
getQuote(c("SPY;WYSIWIG"), src="av")
joshuaulrich commented 4 years ago

This is a great idea! We shouldn't repeat the same code when we can move it to the main function.