search

joshuaulrich / quantmod

Quantitative Financial Modelling Framework
http://www.quantmod.com/
GNU General Public License v3.0
809 stars 223 forks source link

279 get quote resillience 2 #288

Closed ethanbsmith closed 4 years ago

ethanbsmith commented 4 years ago

getQuote would fail if the source did not recognize any of the supplied symbols. this was particularly problematic on large batches where a single failure would cause a stop and there was no way to diagnose which symbol had caused the problem

All getQuote paths now return NA rows for missing quotes centralized row name and missing row handling into master added explicit curl calls as direct fromJSON calls sometimes failed on long symbol lists

joshuaulrich commented 4 years ago

Is the "Update getQuote.R" commit message subject is something that GitHub is automatically doing for you?

I prefer that commit messages use this format, where the subject briefly (in ~50 characters) describes what will happen if the commit is applied.

ethanbsmith commented 4 years ago

probably a github desktop https://desktop.github.com thing. I will watch out for that. apologies

joshuaulrich commented 4 years ago

This is merged, even though GitHub says it's "Closed". I squash-merged from the command line and pushed... assuming it would do the same thing GitHub does. That's what I get for trying not to use the web interface, I guess.