search

joshuaulrich / quantmod

Quantitative Financial Modelling Framework
http://www.quantmod.com/
GNU General Public License v3.0
798 stars 219 forks source link

fixed getMetals() example #331

Closed nachti closed 3 years ago

nachti commented 3 years ago

Please review the contributing guide before submitting your pull request. Please pay special attention to the pull request and commit message sections. Thanks for your contribution and interest in the project!

See #330

joshuaulrich commented 3 years ago

Could you please be patient when submitting issues and PRs? This is your 3rd PR for the same thing, and you've also created an issue. It seems like you've spent a lot of time on this, and I could have helped save some of your time if you had waited.

I've had a lot of family issues the past 3 months (as you can see from my lack of GitHub contributions), so it takes me a lot more time to interact with my open source work, if I can at all.

For future reference, I would appreciate it if you keep everything relevant to one change in a single PR. Opening and closing multiple PRs makes it hard to know which PR is the correct one.

I started fixing this after you opened the issue, so I'm going to use my commit instead of your PR. I hope you understand. Thank you for the report. I do appreciate it!

nachti commented 3 years ago

Sorry for that Joshua! Due to the fact, that it's really a small thing, I tried to fix it using the Github Webinterface directly, which didn't work as I expected (2 commits for 2 files ...). So I cloned the repo and did it there. I wanted to delete the unnecessary PR's, which was not possible - so I closed them. The issue was submitted due to the contribution guide. Thanks for your work and all the best for you and your family! Cheers, Gerhard

joshuaulrich commented 3 years ago

I wanted to delete the unnecessary PR's, which was not possible

In the future, you don't need to delete them. You can revert commits, add new commits, etc. until the final PR is exactly how you want it. Then I can "squash" all your PR commits into a single commit in the main branch. Any incremental commits you make that you don't like won't be in the commit history. There will only be one commit with the final product.

Thanks for your work and all the best for you and your family!

Thanks for the kind words! We're doing better now and I'm starting to respond to all the activity I missed.