search

joshuaulrich / quantmod

Quantitative Financial Modelling Framework
http://www.quantmod.com/
GNU General Public License v3.0
798 stars 219 forks source link

Avoid partial argument name match in legend() #340

Closed ethanbsmith closed 2 years ago

ethanbsmith commented 2 years ago

Fixes #339.

joshuaulrich commented 2 years ago

Thanks! How did you find all of these?

ethanbsmith commented 2 years ago

options(warnPartialMatchArgs = TRUE) options(warn=2)

i was looking for issues in my code and ran into these. probably covered a decent chunk of xts, ttr and quantmod

From: Joshua Ulrich @.> Sent: Tuesday, August 10, 2021 8:09 AM To: joshuaulrich/quantmod @.> Cc: Ethan Smith @.>; Author @.> Subject: Re: [joshuaulrich/quantmod] Avoid partial argument name match in legend() (#340)

Thanks! How did you find all of these?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/joshuaulrich/quantmod/pull/340#issuecomment-895975212, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AF2ACB6FTMDKVAXUSYULTDDT4EJJFANCNFSM5B3HQ5AA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.

joshuaulrich commented 2 years ago

Sorry, I assumed you had that set. I'm looking for a reproducible example that triggers the warning.

FWIW, I have these options set:

warnPartialMatchArgs = TRUE,
warnPartialMatchAttr = TRUE,
warnPartialMatchDollar = TRUE,
ethanbsmith commented 2 years ago

gotcha. ill dig through my code and find whats triggering it. ill add that info back to the underlying issue

From: Joshua Ulrich @.> Sent: Tuesday, August 10, 2021 8:31 AM To: joshuaulrich/quantmod @.> Cc: Ethan Smith @.>; Author @.> Subject: Re: [joshuaulrich/quantmod] Avoid partial argument name match in legend() (#340)

Sorry, I assumed you had that set. I'm looking for a reproducible example that triggers the warning.

FWIW, I have these options set:

warnPartialMatchArgs = TRUE, warnPartialMatchAttr = TRUE, warnPartialMatchDollar = TRUE,

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/joshuaulrich/quantmod/pull/340#issuecomment-895988461, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AF2ACB6XLNN3E3LCHQHB7RDT4ELZ3ANCNFSM5B3HQ5AA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.

joshuaulrich commented 2 years ago

Awesome. No rush. Just thought it would be nice to have a unit test.

ethanbsmith commented 2 years ago

chartSeries(getSymbols("SPY")) addTA(Cl(getSymbols("SPY"))) Warning message: In legend("topleft", legend = @.***$legend.name, ":"), : partial argument match of 'y.inter' to 'y.intersp'

From: Joshua Ulrich @.> Sent: Tuesday, August 10, 2021 9:12 AM To: joshuaulrich/quantmod @.> Cc: Ethan Smith @.>; Author @.> Subject: Re: [joshuaulrich/quantmod] Avoid partial argument name match in legend() (#340)

Awesome. No rush. Just thought it would be nice to have a unit test.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/joshuaulrich/quantmod/pull/340#issuecomment-896016018, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AF2ACB4MHYSZJE7IP53W3YDT4EQTDANCNFSM5B3HQ5AA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.