search

joshuaulrich / quantmod

Quantitative Financial Modelling Framework
http://www.quantmod.com/
GNU General Public License v3.0
798 stars 219 forks source link

used full name #349

Closed ethanbsmith closed 2 years ago

ethanbsmith commented 2 years ago

used full variable names. fixes #348

joshuaulrich commented 2 years ago

Thanks for the fix! No need to make an issue and PR for something simple like a typo. You only need to create an issue first if you're not sure whether it's actually an issue and/or you're not sure the best way to fix it.

joshuaulrich commented 2 years ago

I just noticed that there's another partial match on the same line:

start = cumsum(runs$lengths)[which(runs$values)] - runs$length(((s)))[which(runs$values)]+1,

Can you make that change too? I tried to, but I can't push to your branch.

ethanbsmith commented 2 years ago

done

joshuaulrich commented 2 years ago

Thanks!