joshuaulrich / quantmod

Quantitative Financial Modelling Framework
http://www.quantmod.com/
GNU General Public License v3.0
794 stars 219 forks source link

allReturns ignores subset directive #402

Closed Panagis1980 closed 10 months ago

Panagis1980 commented 10 months ago

Description

allReturns ignores subset directive

Expected behavior

allReturns should calculate for given xts subset

you need to add "subset = subset" in each of the five periodReturn calls like below. it works for me: function (x, subset = NULL, type = "arithmetic", leading = TRUE) { x.orig <- x x <- try.xts(x) all.ret <- cbind(periodReturn(x, "daily",subset = subset, type = type, leading = FALSE), periodReturn(x, "weekly",subset = subset,type = type), periodReturn(x, "monthly",subset = subset, type = type, indexAt = "endof"), periodReturn(x, "quarterly", subset = subset,type = type, indexAt = "endof"), periodReturn(x, "yearly",subset = subset, type = type)) colnames(all.ret) <- c("daily", "weekly", "monthly", "quarterly", "yearly") reclass(all.ret, x.orig) }

Minimal, reproducible example

[Insert sample data and code]

Session Info

[Insert your sessionInfo() output]