Closed TomAndrews closed 4 years ago
Thanks for the report! I would be great if you could come up with a regression test for each instance you've identified where tclass
needs to be passed to the .xts()
constructor.
Thanks for the nice package! I created some tests, as you can see in my pull request.
This is a regression of #249 in 0.12
@TomAndrews, we were so focused on adding tests for the .xts()
constructor that we didn't add any for the actual bug @Eluvias reported! We would have caught this if we had a regression test for reclass()
. I'll make sure one is added.
@philaris thanks for the kind words and the contribution!
I fixed the specific cases mentioned in this issue. Please open a new issue if you find more cases that I missed. Thanks for the report @TomAndrews, and the tests @philaris!
Description
I've come across a few cases in xts 0.12 where tclass gets changed:
and
This is a regression of #249 in 0.12
I think there are a few places where
.indexClass
was passed into the.xts
constructor before andtclass
needs adding in its place.Expected behavior
tclass
should not be adjustedSession Info