Closed jaymon0703 closed 4 years ago
I think it makes sense to include support for ylab
. I'm sure you're not the only person who expected it, since it's exposed in plot()
and plot.zoo()
.
I think we should also include support for sub
and xlab
. Though it may make sense that xlab
throws a warning, since the x-axis is always time for xts objects.
It seems like this would be as simple as adding a title()
call in chart.lines()
if sub
, xlab
, or ylab
are present in ...
. Thoughts?
Agreed on all points. Thanks for taking a look.
On Sat, May 9, 2020 at 8:40 AM Joshua Ulrich notifications@github.com wrote:
I think it makes sense to include support for ylab. I'm sure you're not the only person who expected it, since it's exposed in plot() and plot.zoo().
I think we should also include support for sub and xlab. Though it may make sense that xlab throws a warning, since the x-axis is always time for xts objects.
It seems like this would be as simple as adding a title() call in chart.lines() if sub, xlab, or ylab are present in .... Thoughts?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/joshuaulrich/xts/issues/333#issuecomment-626170190, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBDTPBODWZWVIHWZW52RN3RQVFNNANCNFSM4M25D4PA .
Would you be willing to work on a PR? Please take a look at the contributing guide before you get started.
Sure, thanks
On Sat, May 9, 2020 at 8:50 AM Joshua Ulrich notifications@github.com wrote:
Would you be willing to work on a PR? Please take a look at the contributing guide https://github.com/joshuaulrich/xts/blob/master/.github/CONTRIBUTING.md before you get started.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/joshuaulrich/xts/issues/333#issuecomment-626171407, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBDTPFD6F42FSCE2CNSGQDRQVGQ5ANCNFSM4M25D4PA .
Description
plot.xts does not have nor does it pass a
ylab
argument. Sure i can usetitle()
after the plot function is called, but just wondering if you thinkylab
should be native toplot.xts()
as it is inplot()
?Expected behavior
A little y label appears magically next to the y-axis.
Minimal, reproducible example
Session Info