Use the updated Travis script with bspm

joshuaulrich / xts

Extensible time series class that provides uniform handling of many R time series classes by extending zoo.

http://joshuaulrich.github.io/xts/

GNU General Public License v2.0

220 stars 71 forks source link

Use the updated Travis script with bspm #342

Closed eddelbuettel closed 3 years ago

eddelbuettel commented 3 years ago

Please review the contributing guide before submitting your pull request. Please pay special attention to the pull request and commit message sections. Thanks for your contribution and interest in the project!

joshuaulrich commented 3 years ago

Looks good.

A couple questions, for my reference in case I make these changes in other packages: (1) is removing the R_VERSION="4.0" required? (2) are the quotes necessary for _R_CHECK_DEPENDS_ONLY_="true"?

eddelbuettel commented 3 years ago

Removng R_VERSION=4.0 is not required -- but I find it cleaner to do so as that is now the default value. Quotes for the value is also something I am a little inconsistent about. I think it works with and without (and the conversion to text is implicit). You can change either and set whichever other variable you want -- for now only enabling BSPM is important. I may make that a default in a few months.

joshuaulrich commented 3 years ago

Thanks for the info. I wasn't concerned about either, which is why I merged. I just wanted to understand the rationale, in case it was important. Appreciate it!

eddelbuettel commented 3 years ago

"With quotes" also happens to look neither in most editors for YAML files such as this--uses a different color.