joshuaulrich / xts

Extensible time series class that provides uniform handling of many R time series classes by extending zoo.
http://joshuaulrich.github.io/xts/
GNU General Public License v2.0
219 stars 71 forks source link

Control number of ticks on y-axis #374

Closed FredrikWartenberg closed 1 year ago

FredrikWartenberg commented 2 years ago

Hi Joshua, I have a branch on a local clone of xts with a minor improvement to plot.xts allowing to increase the number of ticks on the y-axis. If it is of general interest, I'd like to make it a pull request, but I have no rights to push my branch. regards, Fredrik

From ?plot.xts yticks.density

Density of tickmarks on y axis. The density will be increased by the given factor (default = 1). The number of tickmarks is determined by means of the pretty function with n = 5 * yticks.desnity.

joshuaulrich commented 2 years ago

Thanks for your contribution!

You have a couple options:

  1. Fork this repo to create a copy under your account. Then make your changes on a branch in that repo. You can submit a pull request once they're committed and pushed to your forked copy.
  2. Use the command line: git checkout {your-branch-name} && git format-patch master. That will create patch files you can send me.

Let me know if you need help with either of those.

FredrikWartenberg commented 2 years ago

Hi Joshua,

Here comes the patch. And thanks a lot for xts!

/Fredrik

From: Joshua Ulrich @.> Sent: Monday, 3 October 2022 20:44 To: joshuaulrich/xts @.> Cc: Fredrik Wartenberg @.>; Author @.> Subject: Re: [joshuaulrich/xts] Control number of ticks on y-axis (Issue #374)

Thanks for your contribution!

You have a couple options:

  1. Fork this repo to create a copy under your account. Then make your changes on a branch in that repo. You can submit a pull request once they're committed and pushed to your forked copy.
  2. Use the command line: git checkout {your-branch-name} && git format-patch master. That will create patch files you can send me.

Let me know if you need help with either of those.

— Reply to this email directly, view it on GitHub https://github.com/joshuaulrich/xts/issues/374#issuecomment-1265880251 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ALBDQFJ5CMOMMJ66U5QW7VLWBMSQJANCNFSM6AAAAAAQ3264MM . You are receiving this because you authored the thread. https://github.com/notifications/beacon/ALBDQFKOHHSVWOSTLYKFUO3WBMSQJA5CNFSM6AAAAAAQ3264MOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSLOPGLW.gif Message ID: @.***>

joshuaulrich commented 2 years ago

@FredrikWartenberg I don't see a patch in your comment. If you attached it to your email, GitHub probably stripped it because you replied to an issue comment. You can send it to my personal email: maintainer("xts").

FredrikWartenberg commented 1 year ago

0001-Add-yticks.density-as-argument-to-plot-allowing-to-c.patch.gz

Hope it works this way