search

joshuaulrich / xts

Extensible time series class that provides uniform handling of many R time series classes by extending zoo.
http://joshuaulrich.github.io/xts/
GNU General Public License v2.0
219 stars 70 forks source link

In window.xts, start and end values of NA will be treated the same as NULL #383

Closed harvey131 closed 1 year ago

harvey131 commented 1 year ago

This is the pull request to support start/end arguments as NA.

345

I was not sure what you meant by testing window.zoo as well.

joshuaulrich commented 1 year ago

I was not sure what you meant by testing window.zoo as well.

xts aims to be consistent w/zoo when possible. So I was asking you to test whether your changes make window.xts() more/less consistent. You'll see that many unit tests compare xts results to zoo.

harvey131 commented 1 year ago

I don't think it will work with zoo because zoo uses is.null(start) and is.null(end) when checking the arguments, and the scope of this pull request would only be for xts. I guess that would require a separate change to the zoo package.

zeileis commented 1 year ago

I have made the separate change to the development version of zoo on R-Forge now (version 1.8-12).

joshuaulrich commented 1 year ago

@harvey131 sorry it took so long to get this merged. Thanks for your contribution!