joshuayapwj98 / pe

0 stars 0 forks source link

[addc] no limit on the number of digits of phone number #2

Open joshuayapwj98 opened 2 years ago

joshuayapwj98 commented 2 years ago

Steps to reproduce

  1. type in the addc command
  2. use an example with long-range digits as the phone number.

    addc n/John Doe p/9876543111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111 a/John street, block 123, #01-01e/johnd@example.com rd/31-03-2022

Expected Display an error message that the phone number is too long.

Actual Successfully added a new customer.

Screenshot

Capture.PNG

nus-pe-script commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Large indices give unexpected error message

When providing an invalid index, the error message expected is:

image.png

However, when giving an index that is too large:

image.png


[original: nus-cs2103-AY2122S2/pe-interim#1990] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

image.png

As mentioned in PE guideline, such input is not considered a bug.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Understand that it is not a usual user behaviour, however, this still serves as an issue as a user can accidentally type in a phone number that exceeds a range, which makes it invalid.


:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.DocumentationBug]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.VeryLow]

Reason for disagreement: [replace this with your explanation]