search

joshuef / safe-js

12 stars 7 forks source link

New apis added #4

Closed hitman401 closed 8 years ago

hitman401 commented 8 years ago

Sign key API and cipher-opts API added. Should allow serialisation and ddserialsisation of sign key. Cipheopts exposes api to create a handle and also to drop the same

joshuef commented 8 years ago

@krishnaIndia on master now, I've removed dist as a folder and added it to .gitignore so we don't get these conflicts/diffs in there (as they'll change everytime), and as we don't need them for the general repo.

(I've added .npmignore which will override this so they're deployed along with the npm release now.)

So I think if you remove those files from the PR it'll be a much simpler merge (if not straight up mergable onto master)

hitman401 commented 8 years ago

@joshuef thanks for the info. Updated the pull request, it is good for a merge now?

joshuef commented 8 years ago

Yup 😄