search

joshvillbrandt / goprohero

A Python library for controlling GoPro cameras over http.
Apache License 2.0
264 stars 57 forks source link

Hero4 support #22

Open lhilton opened 7 years ago

lhilton commented 7 years ago

I am starting to use this library for controlling my camera arrays, and I have found the Hero4 Black support to be spotty. I thought I would take a swing at fixing some of the issues with support. Before I go submitting PR's, do you know if there are outstanding fixes to Hero4/5 support?

joshvillbrandt commented 7 years ago

Hey @lhilton, thanks for your interest!

No outstanding PRs or fixes in the work that I know of.

Please note that I am not actively using this library for myself anymore. I'm happy to review and merge pull requests, but my response times might be a bit slow. (Feel to ping me if I'm taking a while to respond do something though.)

Happy coding!

KonradIT commented 7 years ago

@joshvillbrandt @lhilton , I am PRing HERO5 code to libs including citolen's goproh4 and DenisCarriere's goprohero. I can test with HERO4 too (HERO4 firmware v5.00 introduces new stuff regarding protune). I can add HERO5 features to the lib if you want.

lhilton commented 7 years ago

@KonradIT I was literally just digging into your https://github.com/KonradIT/goprowifihack repo. It looks like you took the path I was just starting to explore, building up dictionaries for each device. Let me know if I can do anything to assist. We have a stack of Hero4 Black's with v5.00 on them. My team can help generate data if you have specifics you are missing.

KonradIT commented 7 years ago

@lhilton I have a H4 Black and Session, a friend of mine has a HERO5 Black so I'll test my commits of goproh4 and deniscarriere/goprohero as soon as I can. I am currently up to my knees with study stuff so I plan to do stuff with karma and then doze off till june. I'd say we split up, I'll update stuff on DenisCarriere's repo and you update HERO4 API/HERO5 on this repo, whatever way you prefer. If you want you can take a look at my commits on citolen's repo to see what I changed.

lhilton commented 7 years ago

Sounds great. I'll dive in tomorrow afternoon and start rolling in as much as I can.

KonradIT commented 7 years ago

@lhilton I decided to make a ruby API wrapper instead, because GoProHERO did not have most functions (it should also work well with HERO5). Quick note for this repo, HERO5 does not respond to /camera/cv , /camera/sx, /camera/se, etc... use /gp/gpControl instead.